Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediago support prebid server #5395

Merged
merged 4 commits into from
Jun 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions dev-docs/bidders/mediago.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@ layout: bidder
title: MediaGo
description: MediaGo Prebid Bidder Adapter
biddercode: mediago
media_types: banner
media_types: banner,native
prebid_member: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't Baidu a member company now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie We did join the prebid.org Slack group. But I'm not so sure if that means we are members.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with my colleague, and we confirmed that we are members. I will update the code accordingly.

userIds: all (with commercial activation)
tcfeu_supported: true
coppa_supported: true
usp_supported: true
pbjs: true
pbs: true
floors_supported: true
gvl_id: 1020
pbjs_version_notes: not ported to 5.x, added back 7.13
Expand All @@ -26,7 +29,8 @@ The MediaGo Bidding adapter requires setup before beginning. Please contact us a
{: .table .table-bordered .table-striped }
| Name | Scope | Description | Example | Type |
|---------------|----------|-----------------------|-----------|-----------|
| `token` | required | publisher token | `'1e100887dd614b7f69fdd1360437'` | `string` |
| `token` | required | publisher token, This parameter expects all imps to be the same | `'1e100887dd614b7f69fdd1360437'` | `string` |
| `region` | recommend | Server region for PBS request: US for US Region, EU for EU Region, APAC for APAC Region, default is US. This parameter expects all imps to be the same. | `'US'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark this parameter as being available for PBS only. Apparently the "test" and "bidfloor" parameters are PBJS only. (though we'd prefer you got rid of the bidfloor param and just read the floor in the standard way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg Thanks for your advice. I have changed it.

| `test` | recommend | 0(default): production env mode. <br> 1: dev env mode and no charge.we will bid Higher frequency to make debug easier. | `1/0` | `Number` |
| `bidfloor` | recommend | Sets a floor price for the bid | `0.05` | `float` |
| `placementId` | recommend | The AD placement ID | `12341234` | `string` |
Loading