-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: bigoad #3711
New Adapter: bigoad #3711
Conversation
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
static/bidder-info/bigoad.yaml
Outdated
- CHN | ||
- RUS | ||
maintainer: | ||
email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prebid team has sent an email to verify above contact email address. Requesting to provide feedback on email thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BIGOAds requesting to address above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. BigoAd had recieved this email.
-----原始邮件-----
发件人:"Onkar Hanumante" ***@***.***>
发送时间:2024-06-05 17:54:38 (星期三)
收件人: prebid/prebid-server ***@***.***>
抄送: BIGOAds ***@***.***>, Mention ***@***.***>
主题: [*Newsletter*] Re: [prebid/prebid-server] New Adapter: bigoad (PR #3711)
@onkarvhanumante commented on this pull request.
In static/bidder-info/bigoad.yaml:
@@ -0,0 +1,20 @@
+endpoint: "http://{{.Host}}/Ad/GetAdOut?sspid={{.SspId}}"
+endpointCompression: gzip
+geoscope:
+ - USA
+ - CHN
+ - RUS
+maintainer:
+ email: ***@***.***
Prebid team has sent an email to verify above contact email address. Requesting to provide feedback on email thread
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
I had fix the problem above, please review again, thanks. |
Hi |
@BIGOAds , ptal at #3711 (comment) comment to proceed with code review |
We sent an email to |
bigoadExt, err := getImpExt(&request.Imp[0]) | ||
if err != nil { | ||
return nil, []error{err} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on line 35 - bigoadExt, err := getImpExt(&request.Imp[0])
looks like Bigoad
expects all imps to use same values for Imp.Ext
@BIGOAds please confirm above behaviour. If all imps should have same values for Imp.Ext
then create/update bidder docs PR to mention this expected behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to mention this in bidder docs PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create doc PR in https://github.com/prebid/prebid.github.io repo and link doc PR in this PR's description.
Refer prebid/prebid.github.io#5395 as example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prebid/prebid.github.io#5349
This is my doc PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
@BIGOAds could you resend response. Prebid team did not received any response |
@BIGOAds ptal at conflicts in following files
|
Thanks,BigoAds Team had recieved this email.
-----原始邮件-----
发件人:"Onkar Hanumante" ***@***.***>
发送时间:2024-06-05 17:54:38 (星期三)
收件人: prebid/prebid-server ***@***.***>
抄送: BIGOAds ***@***.***>, Mention ***@***.***>
主题: [*Newsletter*] Re: [prebid/prebid-server] New Adapter: bigoad (PR #3711)
@onkarvhanumante commented on this pull request.
In static/bidder-info/bigoad.yaml:
@@ -0,0 +1,20 @@
+endpoint: "http://{{.Host}}/Ad/GetAdOut?sspid={{.SspId}}"
+endpointCompression: gzip
+geoscope:
+ - USA
+ - CHN
+ - RUS
+maintainer:
+ email: ***@***.***
Prebid team has sent an email to verify above contact email address. Requesting to provide feedback on email thread
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
|
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
Code coverage summaryNote:
bigoadRefer here for heat map coverage report
|
I am so sorry. My Email is [email protected]. I have updated email in bigoad.yaml. Can you send another email to me? Thanks |
Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread |
I had reply to [email protected]. Is this ok? |
received response 👍🏼 |
@BIGOAds requesting to address #3711 (comment) comment |
Related pull requests in doc PR are linked -> prebid/prebid.github.io#5349 |
@@ -0,0 +1,26 @@ | |||
endpoint: "https://api.imotech.tech/Ad/GetAdOut?sspid={{.SspId}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endpoint is reachable
% curl -i --location --request POST 'https://api.imotech.tech/Ad/GetAdOut?sspid='
HTTP/2 204
server: openresty
date: Wed, 24 Jul 2024 06:19:49 GMT
content-encoding: gzip
bigotraceresponse: 00-797263da055dc8eddc09f1e26ca646f7-0-00
It takes 2 reviews to merge. How can i do for this? |
Related pull requests in prebid.github.io are linked -> prebid/prebid.github.io#5349