Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: bigoad #3711

Merged
merged 9 commits into from
Jul 24, 2024
Merged

New Adapter: bigoad #3711

merged 9 commits into from
Jul 24, 2024

Conversation

BIGOAds
Copy link
Contributor

@BIGOAds BIGOAds commented May 30, 2024

Related pull requests in prebid.github.io are linked -> prebid/prebid.github.io#5349

adapters/bigoad/bigoad.go Outdated Show resolved Hide resolved
adapters/bigoad/bigoad.go Outdated Show resolved Hide resolved
adapters/bigoad/bigoad.go Outdated Show resolved Hide resolved
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a40121d

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		87.5%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		78.9%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:155:	getBidType		85.7%
total:									(statements)		86.2%

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 74967e9

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		87.5%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		80.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		90.9%
total:									(statements)		87.3%

- CHN
- RUS
maintainer:
email: [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prebid team has sent an email to verify above contact email address. Requesting to provide feedback on email thread

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BIGOAds requesting to address above comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jun 7, 2024 via email

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, fccd9b7

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		100.0%
total:									(statements)		93.0%

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jun 12, 2024

I had fix the problem above, please review again, thanks.

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jun 19, 2024

Hi
Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds BIGOAds requested a review from onkarvhanumante June 24, 2024 07:19
@onkarvhanumante
Copy link
Contributor

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

@SyntaxNode
Copy link
Contributor

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

Comment on lines +35 to +39
bigoadExt, err := getImpExt(&request.Imp[0])
if err != nil {
return nil, []error{err}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on line 35 - bigoadExt, err := getImpExt(&request.Imp[0]) looks like Bigoad expects all imps to use same values for Imp.Ext

@BIGOAds please confirm above behaviour. If all imps should have same values for Imp.Ext then create/update bidder docs PR to mention this expected behaviour

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to mention this in bidder docs PR

Copy link
Contributor

@onkarvhanumante onkarvhanumante Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create doc PR in https://github.com/prebid/prebid.github.io repo and link doc PR in this PR's description.

Refer prebid/prebid.github.io#5395 as example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prebid/prebid.github.io#5349
This is my doc PR

Copy link
Contributor

@onkarvhanumante onkarvhanumante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Jul 1, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2baaaa3

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		100.0%
total:									(statements)		93.0%

@onkarvhanumante
Copy link
Contributor

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

1

@BIGOAds could you resend response. Prebid team did not received any response

@onkarvhanumante
Copy link
Contributor

@BIGOAds ptal at conflicts in following files

exchange/adapter_builders.go
openrtb_ext/bidders.go

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 2, 2024 via email

Copy link

github-actions bot commented Jul 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 12aa766

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		100.0%
total:									(statements)		93.0%

Copy link

github-actions bot commented Jul 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9c26cc8

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		100.0%
total:									(statements)		93.0%

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 2, 2024

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

@BIGOAds BIGOAds closed this Jul 2, 2024
@BIGOAds BIGOAds reopened this Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9c26cc8

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		100.0%
total:									(statements)		93.0%

Copy link

github-actions bot commented Jul 2, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 6ebe3cc

bigoad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:34:	MakeRequests		81.8%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:61:	getHeaders		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:71:	addNonEmptyHeaders	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:79:	getImpExt		100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:96:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:101:	MakeBids		90.0%
github.com/prebid/prebid-server/v2/adapters/bigoad/bigoad.go:143:	getBidType		100.0%
total:									(statements)		93.0%

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 2, 2024

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

I am so sorry. My Email is [email protected]. I have updated email in bigoad.yaml. Can you send another email to me? Thanks

@onkarvhanumante
Copy link
Contributor

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

I am so sorry. My Email is [email protected]. I have updated email in bigoad.yaml. Can you send another email to me? Thanks

Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 2, 2024

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

I am so sorry. My Email is [email protected]. I have updated email in bigoad.yaml. Can you send another email to me? Thanks

Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread

I had reply to [email protected]. Is this ok?

@onkarvhanumante
Copy link
Contributor

Hi Are there any news? Should we do something else to pass the review process? Would appreciate any feedback on the topic, thanks.

@BIGOAds , ptal at #3711 (comment) comment to proceed with code review

We sent an email to [email protected] on June 5th to verify and have not received a reply. Did you get our email from [email protected]?

I am so sorry. My Email is [email protected]. I have updated email in bigoad.yaml. Can you send another email to me? Thanks

Prebid team has sent email to verify above maintainers email. Requesting to responding back on email thread

I had reply to [email protected]. Is this ok?

received response 👍🏼

@onkarvhanumante
Copy link
Contributor

@BIGOAds requesting to address #3711 (comment) comment

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 5, 2024

Related pull requests in doc PR are linked -> prebid/prebid.github.io#5349

@BIGOAds BIGOAds requested a review from onkarvhanumante July 17, 2024 02:30
@@ -0,0 +1,26 @@
endpoint: "https://api.imotech.tech/Ad/GetAdOut?sspid={{.SspId}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is reachable

 % curl -i --location --request POST 'https://api.imotech.tech/Ad/GetAdOut?sspid='
HTTP/2 204
server: openresty
date: Wed, 24 Jul 2024 06:19:49 GMT
content-encoding: gzip
bigotraceresponse: 00-797263da055dc8eddc09f1e26ca646f7-0-00

@BIGOAds
Copy link
Contributor Author

BIGOAds commented Jul 24, 2024

It takes 2 reviews to merge. How can i do for this?

@Sonali-More-Xandr Sonali-More-Xandr merged commit 115f773 into prebid:master Jul 24, 2024
5 checks passed
@BIGOAds BIGOAds deleted the bigoad-adapter branch July 25, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants