update bigoad adapter

prebid · May 30, 2024 · 74967e9 · 74967e9
1 parent a40121d
commit 74967e9
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 21 deletions.
diff --git a/adapters/bigoad/bigoad.go b/adapters/bigoad/bigoad.go
@@ -122,23 +122,11 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, _ *adapters.RequestData
 
 	bidResponseWithCapacity := adapters.NewBidderResponseWithBidsCapacity(len(bidResponse.SeatBid[0].Bid))
 
-	// impMap := map[string]*openrtb2.Imp{}
-	// for i := range request.Imp {
-	// 	imp := request.Imp[i]
-	// 	impMap[imp.ID] = &imp
-	// }
-
 	var errors []error
 	seatBid := bidResponse.SeatBid[0]
-	for _, bid := range seatBid.Bid {
-		// imp, exists := impMap[bid.ImpID]
-		// if !exists {
-		// 	errors = append(errors, &errortypes.BadInput{
-		// 		Message: fmt.Sprintf("Invalid bid imp ID #%s does not match any imp IDs from the original bid request", bid.ImpID),
-		// 	})
-		// 	continue
-		// }
-		bidType, err := getBidType(request.Imp[0])
+	for i := range seatBid.Bid {
+		bid := seatBid.Bid[i]
+		bidType, err := getBidType(request.Imp[0], bid)
 		if err != nil {
 			errors = append(errors, err)
 			continue
@@ -152,7 +140,15 @@ func (a *adapter) MakeBids(request *openrtb2.BidRequest, _ *adapters.RequestData
 	return bidResponseWithCapacity, errors
 }
 
-func getBidType(imp openrtb2.Imp) (openrtb_ext.BidType, error) {
+func getBidType(imp openrtb2.Imp, bid openrtb2.Bid) (openrtb_ext.BidType, error) {
+	switch bid.MType {
+	case openrtb2.MarkupBanner:
+		return openrtb_ext.BidTypeBanner, nil
+	case openrtb2.MarkupNative:
+		return openrtb_ext.BidTypeNative, nil
+	case openrtb2.MarkupVideo:
+		return openrtb_ext.BidTypeVideo, nil
+	}
 	if imp.Native != nil {
 		return openrtb_ext.BidTypeNative, nil
 	} else if imp.Banner != nil {
@@ -162,6 +158,6 @@ func getBidType(imp openrtb2.Imp) (openrtb_ext.BidType, error) {
 	}
 
 	return "", &errortypes.BadInput{
-		Message: fmt.Sprintf("Processing an invalid impression; cannot resolve impression type for imp #%s", imp.ID),
+		Message: fmt.Sprintf("unrecognized bid type in response from bigoad %s", imp.ID),
 	}
 }
diff --git a/adapters/bigoad/bigoadtest/exemplary/banner_app.json b/adapters/bigoad/bigoadtest/exemplary/banner_app.json
@@ -123,6 +123,7 @@
                   "id": "test-imp-id",
                   "impid": "test-imp-id",
                   "adid": "11110126",
+                  "mtype": 1,
                   "price": 0.42632559,
                   "adm": "some-test-ad",
                   "adomain": [
@@ -161,6 +162,7 @@
             "adid": "11110126",
             "price": 0.42632559,
             "adm": "some-test-ad",
+            "mtype": 1,
             "adomain": [
               "www.lazada.com"
             ],

diff --git a/adapters/bigoad/bigoadtest/exemplary/native_app.json b/adapters/bigoad/bigoadtest/exemplary/native_app.json
@@ -113,7 +113,8 @@
                                     "adomain": [
                                         "awesome.com"
                                     ],
-                                    "crid": "20"
+                                    "crid": "20",
+                                    "mtype": 4
                                 }
                             ],
                             "type": "native",
@@ -135,6 +136,7 @@
                         "price": 3.5,
                         "adm": "awesome-markup",
                         "crid": "20",
+                        "mtype": 4,
                         "adomain": [
                             "awesome.com"
                         ]

diff --git a/adapters/bigoad/bigoadtest/exemplary/video_app.json b/adapters/bigoad/bigoadtest/exemplary/video_app.json
@@ -125,7 +125,8 @@
                                     ],
                                     "crid": "20",
                                     "w": 1280,
-                                    "h": 720
+                                    "h": 720,
+                                    "mtype": 2
                                 }
                             ],
                             "seat": "bigoad"
@@ -150,7 +151,8 @@
                             "awesome.com"
                         ],
                         "w": 1280,
-                        "h": 720
+                        "h": 720,
+                        "mtype": 2
                     },
                     "type": "video"
                 }

diff --git a/openrtb_ext/bidders.go b/openrtb_ext/bidders.go
@@ -358,6 +358,7 @@ const (
 	BidderBidmyadz          BidderName = "bidmyadz"
 	BidderBidsCube          BidderName = "bidscube"
 	BidderBidstack          BidderName = "bidstack"
+	BidderBigoAd            BidderName = "bigoad"
 	BidderBizzclick         BidderName = "bizzclick"
 	BidderBliink            BidderName = "bliink"
 	BidderBlue              BidderName = "blue"
@@ -511,7 +512,6 @@ const (
 	BidderZeroClickFraud    BidderName = "zeroclickfraud"
 	BidderZetaGlobalSsp     BidderName = "zeta_global_ssp"
 	BidderZmaticoo          BidderName = "zmaticoo"
-	BidderBigoAd            BidderName = "bigoad"
 )
 
 // CoreBidderNames returns a slice of all core bidders.