Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to initialize "pending" blocks in a specific way (add runtime api pending_initialize_block) #1253

Conversation

librelois
Copy link
Contributor

At moonbeam, we necessarily need to initialize "pending" bloks in a different way to classic blocks, because our pallet randomness panics at on_initialize hook if the node doesn't have a VRF key in its keystore.
We need to tell our pallet that we're in the context of a "pending" block built by an RPC provider, and not a normal block. Somehow, we need to modify the client/runtime interface to tell the runtime that we're in the context of a "pending" block, the simplest solution we've found is to add a new method to the runtime API EthereumRuntimeRPCApi.

@librelois librelois requested a review from sorpaas as a code owner November 28, 2023 14:05
@librelois
Copy link
Contributor Author

@sorpaas @boundless-forest can someone merge this PR?

@boundless-forest boundless-forest merged commit cacdfd7 into polkadot-evm:master Aug 1, 2024
4 checks passed
@librelois librelois deleted the elois-pending-runtime-api branch August 1, 2024 09:17
ipapandinas pushed a commit to AstarNetwork/frontier that referenced this pull request Sep 4, 2024
magecnion added a commit to freeverseio/laos that referenced this pull request Sep 12, 2024
asiniscalchi added a commit to freeverseio/laos that referenced this pull request Nov 29, 2024
* uplift to stable2407

* paritytech/polkadot-sdk#4831

* paritytech/polkadot-sdk#3820

* polkadot-evm/frontier#1253

* paritytech/polkadot-sdk#3952

* paritytech/polkadot-sdk#3872

* fix rpc_builder type

* paritytech/polkadot-sdk#4410

* paritytech/polkadot-sdk#4097

* use stable rust toolchain

* paritytech/polkadot-sdk#3964

* cargo fmt

* clippy and lint issues

* e2e-test estimate gas when delegating

* only run staking e2e-test so it's easier for reviewing by external

* only run staking e2e-test so it's easier for reviewing by external

* restore run all e2e tests

* Update Rust Toolchain to 1.77, Suppress Warnings, and Enhance Runtime (#778)

* using runt 1.77

* fix clippy errors

* fixing clippy

* update to runtime 2200

* update proyect version to 0.22.0

* add missing migration

* removed the upgrade of versioning

* update cargo.lock

* using runtime

* fix  command

* fix compilation

* fix metadata test

* missing Config associated type

* modify MaxPageSize to the original till we need to increase it

* use latest release for zombienet tests

* go back to stable2407-3 release for zombienet tests

* go back to previous MaxPageSize

---------

Co-authored-by: Alessandro Siniscalchi <[email protected]>
Co-authored-by: luispdm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants