treasury pallet: remove unused config parameters #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muharem
added
the
T1-FRAME
|
The CI pipeline was cancelled due to failure one of the required jobs. |
muharem
changed the title
ggwpez
approved these changes
Jun 19, 2024
|
@ggwpez is this really supposed to be minor? |
seadanda
approved these changes
Jun 24, 2024
Comment on lines
+12
to
+15
| - name: pallet-bounties | ||
| bump: major | ||
| - name: pallet-tips | ||
| bump: major |
There was a problem hiding this comment.
Updating to this version of tips and bounties with the additional associated type in their Config trait will make runtimes fail to compile without changes, so I think these are correct, despite what the semver check says.
seadanda
reviewed
Jun 24, 2024
joepetrowski
approved these changes
Jun 24, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Remove unused config parameters `ApproveOrigin` and `OnSlash` from the treasury pallet. Add `OnSlash` config parameter to the bounties and tips pallets. part of paritytech#3800
This was referenced Aug 21, 2024
magecnion
added a commit
to freeverseio/laos
that referenced
this pull request
Sep 12, 2024
vedhavyas
added a commit
to AstarNetwork/polkadot-sdk
that referenced
this pull request
Oct 18, 2024
asiniscalchi
added a commit
to freeverseio/laos
that referenced
this pull request
Nov 29, 2024
* uplift to stable2407 * paritytech/polkadot-sdk#4831 * paritytech/polkadot-sdk#3820 * polkadot-evm/frontier#1253 * paritytech/polkadot-sdk#3952 * paritytech/polkadot-sdk#3872 * fix rpc_builder type * paritytech/polkadot-sdk#4410 * paritytech/polkadot-sdk#4097 * use stable rust toolchain * paritytech/polkadot-sdk#3964 * cargo fmt * clippy and lint issues * e2e-test estimate gas when delegating * only run staking e2e-test so it's easier for reviewing by external * only run staking e2e-test so it's easier for reviewing by external * restore run all e2e tests * Update Rust Toolchain to 1.77, Suppress Warnings, and Enhance Runtime (#778) * using runt 1.77 * fix clippy errors * fixing clippy * update to runtime 2200 * update proyect version to 0.22.0 * add missing migration * removed the upgrade of versioning * update cargo.lock * using runtime * fix command * fix compilation * fix metadata test * missing Config associated type * modify MaxPageSize to the original till we need to increase it * use latest release for zombienet tests * go back to stable2407-3 release for zombienet tests * go back to previous MaxPageSize --------- Co-authored-by: Alessandro Siniscalchi <[email protected]> Co-authored-by: luispdm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused config parameters
ApproveOriginandOnSlashfrom the treasury pallet. AddOnSlashconfig parameter to the bounties and tips pallets.part of #3800