Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust Toolchain to 1.77, Suppress Warnings, and Enhance Runtime #778

Merged

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Sep 13, 2024

PR Type

Enhancement, Bug fix


Description

  • Updated Rust toolchain to version 1.77 and suppressed deprecation warnings across multiple files.
  • Removed unnecessary Clippy lint allowances to clean up the code.
  • Updated runtime specification version from 2100 to 2200 and project version to 0.22.0.
  • Added a new migration for the XCMP queue to version 5.
  • Cleaned up unused imports and simplified code in tests.

Changes walkthrough 📝

Relevant files
Enhancement
12 files
eth.rs
Suppress deprecation warnings in Ethereum compatibility module

node/src/eth.rs

  • Added #[allow(deprecated)] attribute to suppress deprecation warnings.

  • +2/-0     
    service.rs
    Suppress deprecation warnings in service module                   

    node/src/service.rs

  • Added #[allow(deprecated)] attribute to suppress deprecation warnings.

  • +2/-0     
    lib.rs
    Remove unnecessary Clippy lint allowance                                 

    pallets/asset-metadata-extender/src/lib.rs

    • Removed #[allow(clippy::manual_inspect)] attribute.
    +0/-1     
    lib.rs
    Remove unnecessary Clippy lint allowance                                 

    pallets/laos-evolution/src/lib.rs

    • Removed #[allow(clippy::manual_inspect)] attribute.
    +0/-1     
    lib.rs
    Remove unnecessary Clippy lint allowance                                 

    pallets/parachain-staking/src/lib.rs

    • Removed #[allow(clippy::manual_inspect)] attribute.
    +0/-1     
    mock.rs
    Remove unnecessary Clippy lint allowance                                 

    pallets/parachain-staking/src/mock.rs

    • Removed #[allow(clippy::manual_inspect)] attribute.
    +0/-1     
    tests.rs
    Clean up and simplify staking tests                                           

    pallets/parachain-staking/src/tests.rs

  • Removed unused imports in the test function.
  • Simplified the Balances::burn call.
  • +1/-4     
    lib.rs
    Remove unnecessary Clippy lint allowance                                 

    pallets/precompiles-benchmark/src/lib.rs

    • Removed #[allow(clippy::manual_inspect)] attribute.
    +0/-1     
    treasury.rs
    Clean up unused imports in treasury configuration               

    runtime/laos/src/configs/treasury.rs

    • Removed unused import currency::UNIT.
    +1/-2     
    lib.rs
    Update runtime specification version                                         

    runtime/laos/src/lib.rs

    • Updated spec_version from 2100 to 2200.
    +1/-1     
    migrations.rs
    Add migration for XCMP queue to version 5                               

    runtime/laos/src/migrations.rs

  • Added new migration MigrateV4ToV5.
  • Implemented V5Config for Runtime.
  • +18/-1   
    config.ts
    Update runtime spec version in E2E tests                                 

    e2e-tests/tests/config.ts

    • Updated RUNTIME_SPEC_VERSION from 2100 to 2200.
    +1/-1     
    Configuration changes
    1 files
    Cargo.toml
    Bump project version to 0.22.0                                                     

    Cargo.toml

    • Updated project version from 0.21.0 to 0.22.0.
    +1/-1     
    Dependencies
    1 files
    rust-toolchain
    Update Rust toolchain to version 1.77                                       

    rust-toolchain

    • Updated Rust toolchain channel to version 1.77.
    +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Using rust 1.77 Update Rust Toolchain to 1.77 and Suppress Warnings Sep 13, 2024
    Copy link

    PR Description updated to latest commit (5327c65)

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Update Rust Toolchain to 1.77 and Suppress Warnings Update Rust Toolchain to 1.77, Suppress Warnings, and Enhance Runtime Sep 13, 2024
    Copy link

    PR Description updated to latest commit (ed08db0)

    @asiniscalchi asiniscalchi merged commit 43737f3 into feature/upgrade-polkadot-sdk-to-stable2407 Sep 13, 2024
    5 of 7 checks passed
    @asiniscalchi asiniscalchi deleted the using_rust_1.77 branch September 13, 2024 11:32
    asiniscalchi added a commit that referenced this pull request Nov 29, 2024
    * uplift to stable2407
    
    * paritytech/polkadot-sdk#4831
    
    * paritytech/polkadot-sdk#3820
    
    * polkadot-evm/frontier#1253
    
    * paritytech/polkadot-sdk#3952
    
    * paritytech/polkadot-sdk#3872
    
    * fix rpc_builder type
    
    * paritytech/polkadot-sdk#4410
    
    * paritytech/polkadot-sdk#4097
    
    * use stable rust toolchain
    
    * paritytech/polkadot-sdk#3964
    
    * cargo fmt
    
    * clippy and lint issues
    
    * e2e-test estimate gas when delegating
    
    * only run staking e2e-test so it's easier for reviewing by external
    
    * only run staking e2e-test so it's easier for reviewing by external
    
    * restore run all e2e tests
    
    * Update Rust Toolchain to 1.77, Suppress Warnings, and Enhance Runtime (#778)
    
    * using runt 1.77
    
    * fix clippy errors
    
    * fixing clippy
    
    * update to runtime 2200
    
    * update proyect version to 0.22.0
    
    * add missing migration
    
    * removed the upgrade of versioning
    
    * update cargo.lock
    
    * using runtime
    
    * fix  command
    
    * fix compilation
    
    * fix metadata test
    
    * missing Config associated type
    
    * modify MaxPageSize to the original till we need to increase it
    
    * use latest release for zombienet tests
    
    * go back to stable2407-3 release for zombienet tests
    
    * go back to previous MaxPageSize
    
    ---------
    
    Co-authored-by: Alessandro Siniscalchi <[email protected]>
    Co-authored-by: luispdm <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants