[Tokenomics] Implement Global Mint Reimbursement Request #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Invalid_SupplierExceedsMaxClaimableAmount
…_pokt_reimbursement_request
…_pokt_reimbursement_request
red-0ne
added
application
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 12819930 | Triggered | Generic Password | ba13177 | localnet/kubernetes/values-pocketdex-postgres.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
bryanchriswhite
previously requested changes
Oct 25, 2024
There was a problem hiding this comment.
I could't quite make it to the end of the last file but I got through 90%+. 🔥
Great work @red-0ne! 🙌
Olshansk
requested changes
Oct 25, 2024
Olshansk
requested changes
Oct 29, 2024
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 878) |
github-actions
bot
added
devnet
push-image
Olshansk
approved these changes
Oct 30, 2024
red-0ne
dismissed
bryanchriswhite’s stale review
Change requests addressed, Bryan is OOO
bryanchriswhite
added a commit
that referenced
this pull request
Nov 4, 2024
…tlement # By Redouane Lakrache (3) and others # Via GitHub * pokt/main: [Observability] Foundation for load testing telemetry (#832) [Tokenomics] Implement Global Mint Reimbursement Request (#878) [Docs] Assign owners to all `TODO_BETA` (#898) [Supplier] Add supplier staking fee (#883) [Application] Single Service Applications (#886) # Conflicts: # testutil/keeper/tokenomics.go # x/tokenomics/keeper/settle_pending_claims.go # x/tokenomics/keeper/token_logic_modules.go # x/tokenomics/keeper/token_logic_modules_test.go # x/tokenomics/module/abci.go # x/tokenomics/types/errors.go
bryanchriswhite
added a commit
that referenced
this pull request
Nov 4, 2024
# By Redouane Lakrache (3) and others # Via GitHub * pokt/main: [Observability] Foundation for load testing telemetry (#832) [Tokenomics] Implement Global Mint Reimbursement Request (#878) [Docs] Assign owners to all `TODO_BETA` (#898) [Supplier] Add supplier staking fee (#883) [Application] Single Service Applications (#886) # Conflicts: # x/supplier/keeper/msg_server_stake_supplier.go # x/supplier/keeper/msg_server_stake_supplier_test.go # x/supplier/keeper/msg_server_unstake_supplier_test.go
okdas
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary This PR adds * GMRR TLM * Ensures that the application has enough funds to cover for it. * Deducts the total global mint amount from the application's stake. * Sends the global mint amount from the application module account to the tokenomics module account to the PNF account. * The application still gets its global inflation share sent to its account. ## Issue - #732 ## Type of change Select one or more from the following: - [x] New feature, functionality or library ## Testing - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <[email protected]>
bryanchriswhite
added a commit
that referenced
this pull request
Nov 14, 2024
…pdates * pokt/main: (51 commits) [RelayMiner] Supplier rate limiting (#895) [Tokenomics] refactor: `MintAllocationApplication` var usage to param usage (#918) [Tokenomics] feat: add `mint_allocation_application` param to tokenomics module (#917) [Tokenomics] refactor: `MintAllocationSourceOwner` var usage to param usage (#916) [Tokenomics] feat: add `mint_allocation_source_owner` param to tokenomics module (#915) [Tokenomics] refactor: `MintAllocationSupplier` var usage to param usage (#914) [Tokenomics] feat: add `mint_allocation_supplier` param to tokenomics module (#913) [Tokenomics] refactor: `MintAllocationProposer` var usage to param usage (#912) [Tokenomics] feat: add `mint_allocation_proposer` param to tokenomics module (#911) [Tokenomics] refactor: `MintAllocationDao` var usage to param usage (#910) [Tokenomics] Add `mint_allocation_dao` tokenomics module param (#909) [quick-pr] change full-node.sh script links (#920) [Supplier] refactor: `NumSuppliersPerSession` var usage to param usage (#908) [Session Params] Add `num_suppliers_per_session` param to session module (#907) [Session Params] Add `MsgUpdateParam` to session module (#906) Updated some compiled proto files [TODOs] Update #2 to `TODO_BETA` to only reflect ACTUAL blockers (#900) [Workflow] Enforce `TODO_UPNEXT` comments to have an associated username (#896) [Observability] Foundation for load testing telemetry (#832) [Tokenomics] Implement Global Mint Reimbursement Request (#878) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
Issue
Type of change
Select one or more from the following:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist