Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tokenomics] Add mint_allocation_dao tokenomics module param #909

Merged
merged 36 commits into from
Nov 13, 2024
Merged

[Tokenomics] Add mint_allocation_dao tokenomics module param #909

merged 36 commits into from
Nov 13, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Nov 8, 2024 •
edited
Loading

Summary

Add mint_allocation_dao param to the tokenomics module.

Issue

  • TODO_BETA

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added governance Governance related changes on-chain On-chain business logic devnet-test-e2e tokenomics Token Economics - what else do you need? labels Nov 8, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 909)
Grafana network dashboard for devnet-issue-909

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 8, 2024
@bryanchriswhite bryanchriswhite force-pushed the todo_beta/params/mint_alloc_dao branch from a161ae4 to 6a58a85 Compare November 8, 2024 12:45
@bryanchriswhite bryanchriswhite force-pushed the todo_beta/params/mint_alloc_dao branch from 6a58a85 to d77eeef Compare November 8, 2024 12:49
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 8, 2024 12:54
@bryanchriswhite
Merge remote-tracking branch 'pokt/todo_beta/refactor/num_suppliers_p…
45b1bf4 
…er_session' into todo_beta/params/mint_alloc_dao

* pokt/todo_beta/refactor/num_suppliers_per_session:
  fix: session module param make targets
@bryanchriswhite
fix: typo
e8e09e9
@bryanchriswhite
test: mint_allocation_dao validation
ca68ba6
red-0ne
red-0ne reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I feel like we could consolidate the double, float64, float terms.

makefiles/params.mk
@@ -14,9 +14,9 @@ params_get_tokenomics: ## Get the tokenomics module params
params_update_tokenomics_all: ## Update the tokenomics module params
poktrolld tx authz exec ./tools/scripts/params/tokenomics_all.json $(PARAM_FLAGS)

.PHONY: params_update_tokenomics_compute_units_to_tokens_multiplier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

testutil/integration/suites/param_configs.go Outdated Show resolved Hide resolved
tools/scripts/params/tokenomics_mint_allocation_dao.json Show resolved Hide resolved
x/tokenomics/types/message_update_param.go Outdated Show resolved Hide resolved
bryanchriswhite and others added 3 commits November 12, 2024 11:51
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into todo_beta/params/num_su…
2dd77a3 
…pplier_per_session

* pokt/main:
  [Session Params] Add `MsgUpdateParam` to session module (#906)
  Updated some compiled proto files
@bryanchriswhite @red-0ne
chore: review feedback improvements
9a4fcfe 
Co-authored-by: Redouane Lakrache <[email protected]>
@bryanchriswhite
refactor: consolidate float params to float64
f06276d
red-0ne
red-0ne approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bryanchriswhite bryanchriswhite changed the base branch from todo_beta/refactor/num_suppliers_per_session to main November 12, 2024 13:51
@bryanchriswhite bryanchriswhite added devnet-test-e2e and removed push-image CI related - pushes images to ghcr.io devnet devnet-test-e2e labels Nov 12, 2024
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 909)
Grafana network dashboard for devnet-issue-909

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 12, 2024
@bryanchriswhite bryanchriswhite merged commit d1978e3 into main Nov 13, 2024
11 checks passed
@bryanchriswhite bryanchriswhite deleted the todo_beta/params/mint_alloc_dao branch November 13, 2024 09:12
bryanchriswhite added a commit that referenced this pull request Nov 13, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into todo_beta/refactor/mint…
fb381dc 
…_allocation_application

* pokt/main:
  [Tokenomics] feat: add `mint_allocation_application` param to tokenomics module (#917)
  [Tokenomics] refactor: `MintAllocationSourceOwner` var usage to param usage (#916)
  [Tokenomics] feat: add `mint_allocation_source_owner` param to tokenomics module (#915)
  [Tokenomics] refactor: `MintAllocationSupplier` var usage to param usage (#914)
  [Tokenomics] feat: add `mint_allocation_supplier` param to tokenomics module (#913)
  [Tokenomics] refactor: `MintAllocationProposer` var usage to param usage (#912)
  [Tokenomics] feat: add `mint_allocation_proposer` param to tokenomics module (#911)
  [Tokenomics] refactor: `MintAllocationDao` var usage to param usage (#910)
  [Tokenomics] Add `mint_allocation_dao` tokenomics module param (#909)
  [quick-pr] change full-node.sh script links (#920)
  [Supplier] refactor: `NumSuppliersPerSession` var usage to param usage (#908)
bryanchriswhite added a commit that referenced this pull request Nov 14, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/612/docs/param-u…
8b6b2c5 
…pdates

* pokt/main: (51 commits)
  [RelayMiner] Supplier rate limiting (#895)
  [Tokenomics] refactor: `MintAllocationApplication` var usage to param usage  (#918)
  [Tokenomics] feat: add `mint_allocation_application` param to tokenomics module (#917)
  [Tokenomics] refactor: `MintAllocationSourceOwner` var usage to param usage (#916)
  [Tokenomics] feat: add `mint_allocation_source_owner` param to tokenomics module (#915)
  [Tokenomics] refactor: `MintAllocationSupplier` var usage to param usage (#914)
  [Tokenomics] feat: add `mint_allocation_supplier` param to tokenomics module (#913)
  [Tokenomics] refactor: `MintAllocationProposer` var usage to param usage (#912)
  [Tokenomics] feat: add `mint_allocation_proposer` param to tokenomics module (#911)
  [Tokenomics] refactor: `MintAllocationDao` var usage to param usage (#910)
  [Tokenomics] Add `mint_allocation_dao` tokenomics module param (#909)
  [quick-pr] change full-node.sh script links (#920)
  [Supplier] refactor: `NumSuppliersPerSession` var usage to param usage (#908)
  [Session Params] Add `num_suppliers_per_session` param to session module (#907)
  [Session Params] Add `MsgUpdateParam` to session module (#906)
  Updated some compiled proto files
  [TODOs] Update #2 to `TODO_BETA` to only reflect ACTUAL blockers (#900)
  [Workflow] Enforce `TODO_UPNEXT` comments to have an associated username (#896)
  [Observability] Foundation for load testing telemetry (#832)
  [Tokenomics] Implement Global Mint Reimbursement Request (#878)
  ...
bryanchriswhite added a commit that referenced this pull request Nov 14, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/881/refactor/set…
97f94f4 
…tlement

* pokt/main:
  [RelayMiner] Supplier rate limiting (#895)
  [Tokenomics] refactor: `MintAllocationApplication` var usage to param usage  (#918)
  [Tokenomics] feat: add `mint_allocation_application` param to tokenomics module (#917)
  [Tokenomics] refactor: `MintAllocationSourceOwner` var usage to param usage (#916)
  [Tokenomics] feat: add `mint_allocation_source_owner` param to tokenomics module (#915)
  [Tokenomics] refactor: `MintAllocationSupplier` var usage to param usage (#914)
  [Tokenomics] feat: add `mint_allocation_supplier` param to tokenomics module (#913)
  [Tokenomics] refactor: `MintAllocationProposer` var usage to param usage (#912)
  [Tokenomics] feat: add `mint_allocation_proposer` param to tokenomics module (#911)
  [Tokenomics] refactor: `MintAllocationDao` var usage to param usage (#910)
  [Tokenomics] Add `mint_allocation_dao` tokenomics module param (#909)
  [quick-pr] change full-node.sh script links (#920)
  [Supplier] refactor: `NumSuppliersPerSession` var usage to param usage (#908)
  [Session Params] Add `num_suppliers_per_session` param to session module (#907)
  [Session Params] Add `MsgUpdateParam` to session module (#906)
  Updated some compiled proto files
  [TODOs] Update #2 to `TODO_BETA` to only reflect ACTUAL blockers (#900)
  [Workflow] Enforce `TODO_UPNEXT` comments to have an associated username (#896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

Assignees

@bryanchriswhite bryanchriswhite

Labels
devnet devnet-test-e2e governance Governance related changes on-chain On-chain business logic push-image CI related - pushes images to ghcr.io tokenomics Token Economics - what else do you need?
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @red-0ne