[Application] Single Service Applications #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
red-0ne
added
application
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 886) |
github-actions
bot
added
devnet
push-image
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 12819930 | Triggered | Generic Password | 57e7f8c | localnet/kubernetes/values-pocketdex-postgres.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Olshansk
requested changes
Oct 24, 2024
bryanchriswhite
approved these changes
Oct 25, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Nov 4, 2024
…tlement # By Redouane Lakrache (3) and others # Via GitHub * pokt/main: [Observability] Foundation for load testing telemetry (#832) [Tokenomics] Implement Global Mint Reimbursement Request (#878) [Docs] Assign owners to all `TODO_BETA` (#898) [Supplier] Add supplier staking fee (#883) [Application] Single Service Applications (#886) # Conflicts: # testutil/keeper/tokenomics.go # x/tokenomics/keeper/settle_pending_claims.go # x/tokenomics/keeper/token_logic_modules.go # x/tokenomics/keeper/token_logic_modules_test.go # x/tokenomics/module/abci.go # x/tokenomics/types/errors.go
bryanchriswhite
added a commit
that referenced
this pull request
Nov 4, 2024
# By Redouane Lakrache (3) and others # Via GitHub * pokt/main: [Observability] Foundation for load testing telemetry (#832) [Tokenomics] Implement Global Mint Reimbursement Request (#878) [Docs] Assign owners to all `TODO_BETA` (#898) [Supplier] Add supplier staking fee (#883) [Application] Single Service Applications (#886) # Conflicts: # x/supplier/keeper/msg_server_stake_supplier.go # x/supplier/keeper/msg_server_stake_supplier_test.go # x/supplier/keeper/msg_server_unstake_supplier_test.go
okdas
added a commit
that referenced
this pull request
Nov 14, 2024
## Summary This PR enforces staking `Application`s to have a single service, updates the tests and add documentation about the reasoning behind this enforcement. Note that the `Application.ServiceConfigs` remains a slice, reducing the codebase diff and allowing future multi-service `Applications` ## Issue Having `MaxClaimableAmount = Application.Stake * numSessionSuppliers` could allow `Application`s to over-service by making `Supplier`s of different session claim from the same stake.  - #750 (comment) ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [x] Documentation ## Testing - [x] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [ ] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Dmitry K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enforces staking
Applications to have a single service, updates the tests and add documentation about the reasoning behind this enforcement.Note that the
Application.ServiceConfigsremains a slice, reducing the codebase diff and allowing future multi-serviceApplicationsIssue
Having
MaxClaimableAmount = Application.Stake * numSessionSupplierscould allowApplications to over-service by makingSuppliers of different session claim from the same stake.Type of change
Select one or more from the following:
Testing
make docusaurus_start; only needed if you make doc changesmake go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR.Sanity Checklist