Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin/manage changelog misses some changes #60

Closed
mauritsvanrees opened this issue Sep 15, 2023 · 0 comments · Fixed by #61
Closed

bin/manage changelog misses some changes #60

mauritsvanrees opened this issue Sep 15, 2023 · 0 comments · Fixed by #61
Assignees
@mauritsvanrees

Comments

@mauritsvanrees
Copy link
Member

See these two commits where I manually added one or more changelog entries:

I think something in our logic goes wrong when a package has both a "Bug fixes" header and an "Internal" header: the bug fixes get forgotten, and the internal fixes end up under "Bug fixes". Probably the new towncrier categories we defined in plone/meta need extra handling here.

Should be somewhere around these lines or we need to add them here.

Also see #48 where we need to support searching in Markdown files. That might be a simple addition here. Could be that we then end up with invalid ReStructuredText though, in the total changelog.txt.
@mauritsvanrees mauritsvanrees self-assigned this Sep 15, 2023
mauritsvanrees added a commit that referenced this issue Sep 18, 2023
@mauritsvanrees
Fix missing changelog entries when running bin/manage changelog.
b94683f 
Fixes #60
@mauritsvanrees mauritsvanrees mentioned this issue Sep 18, 2023
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 18, 2023
@mauritsvanrees
[fc] Repository: plone.releaser
f9d0391 
Branch: refs/heads/master
Date: 2023-09-18T23:57:44+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@b94683f

Fix missing changelog entries when running `bin/manage changelog`.

Fixes plone/plone.releaser#60

Files changed:
A news/60.bugfix
A plone/releaser/tests/input/changes.rst
A plone/releaser/tests/test_changelog.py
M plone/releaser/changelog.py
M plone/releaser/release.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-19T00:08:49+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@d99745b

Merge pull request #61 from plone/maurits-changelog

Fix missing changelog entries when running `bin/manage changelog`.

Files changed:
A news/60.bugfix
A plone/releaser/tests/input/changes.rst
A plone/releaser/tests/test_changelog.py
M plone/releaser/changelog.py
M plone/releaser/release.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Sep 18, 2023
@mauritsvanrees
[fc] Repository: plone.releaser
a1145ba 
Branch: refs/heads/master
Date: 2023-09-18T23:57:44+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@b94683f

Fix missing changelog entries when running `bin/manage changelog`.

Fixes plone/plone.releaser#60

Files changed:
A news/60.bugfix
A plone/releaser/tests/input/changes.rst
A plone/releaser/tests/test_changelog.py
M plone/releaser/changelog.py
M plone/releaser/release.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-09-19T00:08:49+02:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@d99745b

Merge pull request #61 from plone/maurits-changelog

Fix missing changelog entries when running `bin/manage changelog`.

Files changed:
A news/60.bugfix
A plone/releaser/tests/input/changes.rst
A plone/releaser/tests/test_changelog.py
M plone/releaser/changelog.py
M plone/releaser/release.py
mauritsvanrees added a commit that referenced this issue Sep 21, 2023
@mauritsvanrees
Fix missing changelog entries when running bin/manage changelog.
0bac2e6 
Fixes #60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing changelog entries when running bin/manage changelog. plone/plone.releaser
1 participant
@mauritsvanrees