Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manage changelog fails to read markdown files #48

Closed
mauritsvanrees opened this issue Feb 23, 2023 · 1 comment
Closed

manage changelog fails to read markdown files #48

mauritsvanrees opened this issue Feb 23, 2023 · 1 comment

Comments

@mauritsvanrees
Copy link
Member

mauritsvanrees commented Feb 23, 2023 •
edited
Loading

I am running this now:

$ bin/manage changelog --start=6.0.1 > release/changelog.txt

Several packages have their changelog in CHANGES.md now, and they are not found yet.
For example for the Plone package I get this:

Unable to reach https://raw.githubusercontent.com/plone/Plone/master/CHANGES.rst
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/CHANGES.txt
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/HISTORY.rst
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/HISTORY.txt
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/docs/CHANGES.rst
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/docs/CHANGES.txt
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/docs/HISTORY.rst
Unable to reach https://raw.githubusercontent.com/plone/Plone/master/docs/HISTORY.txt

I will do it manually this time for those packages. Currently Plone, CMFPlone and plone.app.caching.
[Update: also plonetheme.barceloneta.]
@mauritsvanrees mauritsvanrees mentioned this issue Sep 15, 2023
Closed
@mauritsvanrees
Copy link
Member Author

This needs an addition here. But then during parsing, this line does not get any sections.

@mauritsvanrees mauritsvanrees mentioned this issue Dec 7, 2023
Merged
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Dec 8, 2023
@gforcada
[fc] Repository: plone.releaser
d550ef8 
Branch: refs/heads/master
Date: 2023-12-01T00:05:10+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@cbd412f

Manage changelog: read markdown files as well.

Fixes plone/plone.releaser#48

Files changed:
A news/48.bugfix
A plone/releaser/tests/input/changes.md
M plone/releaser/changelog.py
M plone/releaser/tests/test_changelog.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-12-05T18:51:55+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@2368be5

In Changelog turn bytes content into string.

Files changed:
M plone/releaser/changelog.py
M plone/releaser/tests/test_changelog.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-12-07T10:23:35+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@849d81b

manage changelog: add --package option.

I see a problem getting the changelog from plone.restapi, so it is useful to be able to restrict the command to this package.
Found the problem: the start version of plone.restapi is not included in its CHANGES.rst on the main branch.
Explained this corner case in the new help text.

Files changed:
M plone/releaser/changelog.py
M plone/releaser/manage.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-12-08T13:06:23+01:00
Author: Gil Forcada Codinachs (gforcada) <[email protected]>
Commit: plone/plone.releaser@518ab4e

Merge pull request #63 from plone/maurits-changelog-parse-markdown

Manage changelog: read markdown files as well.

Files changed:
A news/48.bugfix
A plone/releaser/tests/input/changes.md
M plone/releaser/changelog.py
M plone/releaser/manage.py
M plone/releaser/tests/test_changelog.py
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Dec 8, 2023
@gforcada
[fc] Repository: plone.releaser
ad5496f 
Branch: refs/heads/master
Date: 2023-12-01T00:05:10+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@cbd412f

Manage changelog: read markdown files as well.

Fixes plone/plone.releaser#48

Files changed:
A news/48.bugfix
A plone/releaser/tests/input/changes.md
M plone/releaser/changelog.py
M plone/releaser/tests/test_changelog.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-12-05T18:51:55+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@2368be5

In Changelog turn bytes content into string.

Files changed:
M plone/releaser/changelog.py
M plone/releaser/tests/test_changelog.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-12-07T10:23:35+01:00
Author: Maurits van Rees (mauritsvanrees) <[email protected]>
Commit: plone/plone.releaser@849d81b

manage changelog: add --package option.

I see a problem getting the changelog from plone.restapi, so it is useful to be able to restrict the command to this package.
Found the problem: the start version of plone.restapi is not included in its CHANGES.rst on the main branch.
Explained this corner case in the new help text.

Files changed:
M plone/releaser/changelog.py
M plone/releaser/manage.py
Repository: plone.releaser

Branch: refs/heads/master
Date: 2023-12-08T13:06:23+01:00
Author: Gil Forcada Codinachs (gforcada) <[email protected]>
Commit: plone/plone.releaser@518ab4e

Merge pull request #63 from plone/maurits-changelog-parse-markdown

Manage changelog: read markdown files as well.

Files changed:
A news/48.bugfix
A plone/releaser/tests/input/changes.md
M plone/releaser/changelog.py
M plone/releaser/manage.py
M plone/releaser/tests/test_changelog.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mauritsvanrees