-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix missing changelog entries when running
bin/manage changelog
.
Fixes #60
- Loading branch information
1 parent
f379ce5
commit 0bac2e6
Showing
5 changed files
with
69 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Fix missing changelog entries when running ``bin/manage changelog``. | ||
[maurits] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
Example changelog from plone.dexterity. | ||
At some point the bug fixes were missing, and the internal item was filed under bug fixes. | ||
See https://github.com/plone/plone.releaser/issues/60 | ||
|
||
|
||
3.0.3 (2023-09-01) | ||
------------------ | ||
|
||
Bug fixes: | ||
|
||
|
||
- Respect locally allowed types when pasting objects [cekk] (#146) | ||
- Fix a memory leak as reported in https://github.com/plone/Products.CMFPlone/issues/3829, changing interface declaration type as suggested by @d-maurer in https://github.com/plone/plone.dexterity/issues/186 [mamico] (#187) | ||
|
||
|
||
Internal: | ||
|
||
|
||
- Update configuration files. | ||
[plone devs] (55bda5c9) | ||
|
||
|
||
3.0.2 (2023-03-14) | ||
------------------ | ||
|
||
Bug fixes: | ||
|
||
|
||
- Type error is removed and none is returned. | ||
In this modified version of the code, if no primary field adapter is found, the fieldname and field attributes are set to None. | ||
The value property checks whether the field attribute is None, and returns None if it is, instead of raising an error. | ||
[Coder-aadarsh] (#59) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
from plone.releaser.changelog import Changelog | ||
|
||
import pathlib | ||
|
||
|
||
TESTS_DIR = pathlib.Path(__file__).parent | ||
INPUT_DIR = TESTS_DIR / "input" | ||
CHANGES_FILE = INPUT_DIR / "changes.rst" | ||
|
||
|
||
def test_get_changes(): | ||
cf = Changelog(CHANGES_FILE) | ||
assert "3.0.2" in cf | ||
assert "3.0.3" in cf | ||
assert sorted(list(cf.get("3.0.3").keys())) == ["Bug fixes:", "Internal:", "other"] | ||
assert cf.get_changes("3.0.3") == [] | ||
assert cf.get_changes("3.0.2") == [ | ||
"Bug fixes:", | ||
"Respect locally allowed types when pasting objects [cekk] (#146)", | ||
"Fix a memory leak as reported in " | ||
"https://github.com/plone/Products.CMFPlone/issues/3829, changing interface " | ||
"declaration type as suggested by @d-maurer in " | ||
"https://github.com/plone/plone.dexterity/issues/186 [mamico] (#187)", | ||
"Internal:", | ||
"Update configuration files.\n[plone devs] (55bda5c9)", | ||
] |