Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AccountId deserialization accept prefixes larger than 1 byte #2686

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

arrudagates
Copy link
Contributor

This fixes the issue described in #2685 however it doesn't properly solve it in a clean manner. A perfect solution would be to somehow retrieve the prefix length from the current chain and use that as the offset for the account id byte array.

@arrudagates arrudagates requested a review from tomaka as a code owner August 25, 2022 14:58
@tomaka
Copy link
Contributor

tomaka commented Aug 25, 2022

Thanks! Could you add an entry in bin/wasm-node/CHANGELOG.md as well?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────
          +6 ┊ <smoldot::json_rpc::methods::AccountId as serde::de::Deserialize>::deserialize::h10e506bd54f2bc1f
          +6 ┊ Σ [1 Total Rows]

@arrudagates
Copy link
Contributor Author

Thanks! Could you add an entry in bin/wasm-node/CHANGELOG.md as well?

Done!

bin/wasm-node/CHANGELOG.md Outdated Show resolved Hide resolved
@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants