New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC AccountId deserialization rejects prefixes larger than 1 byte #2685

Closed

arrudagates opened this issue Aug 25, 2022 · 1 comment

Contributor

arrudagates commented Aug 25, 2022

This line is the main cause of the problem: https://github.com/paritytech/smoldot/blob/main/src/json_rpc/methods.rs#L576
But the lines below also need to be changed to accommodate for more prefix lengths.

arrudagates mentioned this issue

Make AccountId deserialization accept prefixes larger than 1 byte #2686

Merged

Contributor

tomaka commented Aug 30, 2022

Closing after #2686

While the issue isn't "properly" fixed, I think it's "fixed enough" for the foreseeable future.

tomaka closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment