Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process enqueued messages on idle #3844

Merged

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented Mar 26, 2024

🚨 Bug Alert: This change was found to introduce an issue. Please ensure that you either have this fix applied #6205 or disable it by setting IdleMaxServiceWeight = ().


This will make it possible to use remaining weight on idle for processing enqueued messages.
More context here #3709

@ermalkaleci ermalkaleci requested a review from a team as a code owner March 26, 2024 14:48
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5664155

@ermalkaleci ermalkaleci requested review from athei and a team as code owners March 26, 2024 16:51
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 26, 2024 16:52
substrate/frame/message-queue/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/message-queue/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

cumulus/parachains/runtimes/testing/penpal/src/lib.rs Outdated Show resolved Hide resolved
@acatangiu
Copy link
Contributor

Also needs a prdoc. (e.g. https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_3696.prdoc)

@acatangiu acatangiu added the T2-pallets This PR/Issue is related to a particular pallet. label Mar 27, 2024
prdoc/pr_3844.prdoc Outdated Show resolved Hide resolved
@acatangiu acatangiu enabled auto-merge March 27, 2024 14:17
prdoc/pr_3844.prdoc Outdated Show resolved Hide resolved
@acatangiu acatangiu added this pull request to the merge queue Mar 27, 2024
Merged via the queue into paritytech:master with commit 8342947 Mar 27, 2024
122 of 132 checks passed
@ermalkaleci ermalkaleci deleted the process-enqueued-messages-on-idle branch March 27, 2024 15:59
@Morganamilo Morganamilo mentioned this pull request Apr 4, 2024
12 tasks
dharjeezy pushed a commit to dharjeezy/polkadot-sdk that referenced this pull request Apr 9, 2024
This will make it possible to use remaining weight on idle for
processing enqueued messages.
More context here paritytech#3709

---------

Co-authored-by: Adrian Catangiu <[email protected]>
ggwpez added a commit to polkadot-fellows/runtimes that referenced this pull request Sep 25, 2024
fellowship-merge-bot bot added a commit to polkadot-fellows/runtimes that referenced this pull request Sep 26, 2024
Also mention paritytech/polkadot-sdk#3844

Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
AurevoirXavier added a commit to darwinia-network/darwinia that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants