Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to polkadot-sdk v1.11.0 #2838

Merged
merged 50 commits into from
Jun 25, 2024
Merged

Upgrade to polkadot-sdk v1.11.0 #2838

merged 50 commits into from
Jun 25, 2024

Conversation

ahmadkaouk
Copy link
Contributor

@ahmadkaouk ahmadkaouk commented Jun 3, 2024

What does it do?

This PR updates polkadot-sdk from v1.7.2 to v1.11.0

What important points reviewers should know?

Polkadot-sdk

Frontier

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

Polkadot-sdk

What value does it bring to the blockchain users?

@ahmadkaouk ahmadkaouk force-pushed the moonbeam-polkadot-v1.11.0 branch from 3d6525b to 8873c20 Compare June 10, 2024 05:30
@ahmadkaouk ahmadkaouk self-assigned this Jun 14, 2024
@ahmadkaouk ahmadkaouk added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes labels Jun 14, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Coverage Report

@@                      Coverage Diff                      @@
##           master   moonbeam-polkadot-v1.11.0      +/-   ##
=============================================================
+ Coverage   81.23%                      81.34%   +0.11%     
  Files         301                         301              
+ Lines       85514                       85698     +184     
=============================================================
+ Hits        69462                       69704     +242     
- Misses      16052                       15994      -58     
Files Changed Coverage
/node/cli/src/command.rs 19.23% (+0.07%) 🔼
/node/service/src/lib.rs 61.64% (+0.26%) 🔼
/node/service/src/rpc.rs 84.90% (-2.29%) 🔽
/pallets/erc20-xcm-bridge/src/mock.rs 13.33% (+13.33%) 🔼
/pallets/moonbeam-orbiters/src/lib.rs 74.71% (+1.95%) 🔼
/pallets/parachain-staking/src/lib.rs 91.73% (+0.86%) 🔼
/primitives/xcm/src/asset_id_conversions.rs 47.62% (+0.25%) 🔼
/runtime/common/src/apis.rs 30.52% (-1.07%) 🔽
/runtime/common/src/migrations.rs 97.95% (+97.95%) 🔼
/runtime/common/src/weights/pallet_scheduler.rs 12.12% (-5.58%) 🔽
/runtime/moonbase/src/lib.rs 53.45% (-0.27%) 🔽
/runtime/moonbase/src/migrations.rs 100.00% (+100.00%) 🔼
/runtime/moonbase/src/xcm_config.rs 54.35% (-1.21%) 🔽
/runtime/moonbase/tests/xcm_mock/relay_chain.rs 51.61% (-1.72%) 🔽
/runtime/moonbeam/src/lib.rs 47.29% (-0.23%) 🔽
/runtime/moonbeam/src/migrations.rs 66.67% (+66.67%) 🔼
/runtime/moonbeam/src/xcm_config.rs 54.35% (-1.21%) 🔽
/runtime/moonbeam/tests/xcm_mock/relay_chain.rs 51.61% (-1.72%) 🔽
/runtime/moonriver/src/lib.rs 47.37% (-0.23%) 🔽
/runtime/moonriver/src/migrations.rs 66.67% (+66.67%) 🔼
/runtime/moonriver/src/xcm_config.rs 52.17% (-1.16%) 🔽
/runtime/moonriver/tests/xcm_mock/relay_chain.rs 51.61% (-1.72%) 🔽

Coverage generated Tue Jun 25 07:58:21 UTC 2024

client/rpc/debug/src/lib.rs Outdated Show resolved Hide resolved
@RomarQ RomarQ marked this pull request as ready for review June 20, 2024 11:53
RomarQ
RomarQ previously approved these changes Jun 20, 2024
@RomarQ RomarQ requested review from librelois and Agusrodri June 24, 2024 07:58
@librelois
Copy link
Collaborator

• pallet-xcm: Deprecate execute and send in favor of execute_blob and send_blob paritytech/polkadot-sdk#3749

This PR is not in our polkadot-sdk fork branch moonbeam-polkadot-v1.11, I think it's fine to not include it, but then we should not mention it in the changes, @RomarQ do you agree?

node/service/src/rpc.rs Outdated Show resolved Hide resolved
@RomarQ
Copy link
Contributor

RomarQ commented Jun 24, 2024

• pallet-xcm: Deprecate execute and send in favor of execute_blob and send_blob paritytech/polkadot-sdk#3749

This PR is not in our polkadot-sdk fork branch moonbeam-polkadot-v1.11, I think it's fine to not include it, but then we should not mention it in the changes, @RomarQ do you agree?

I agree, the change was reverted in paritytech/polkadot-sdk#4290

RomarQ
RomarQ previously approved these changes Jun 24, 2024
librelois
librelois previously approved these changes Jun 24, 2024
@RomarQ RomarQ dismissed stale reviews from librelois and themself via 5e8a3b5 June 24, 2024 21:22
@RomarQ RomarQ merged commit 223c623 into master Jun 25, 2024
27 checks passed
@RomarQ RomarQ deleted the moonbeam-polkadot-v1.11.0 branch June 25, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants