Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ⏫ upgrade to Polkadot SDK v1.10.0 #210

Merged
merged 20 commits into from
Oct 3, 2024
Merged

Conversation

TDemeco
Copy link
Contributor

@TDemeco TDemeco commented Sep 27, 2024

This PR upgrades dependencies to polkadot-sdk v1.10.0. Notable changes:

  • Node dev changes:
    • #3521 & #3302 Collator-side for elastic scaling: feature flag --elastic-scaling-experimental
    • #3795 Enables collators to build on multiple cores for a single relay chain block
    • #3950 Add ClaimQueueSnapshot with get_claim_for and iter_claims_at_depth methods, useful for checking which parachains had claims over which cores at a certain depth (blocks in the future, depth 0 = very next block)
    • #3580 Expose the ClaimQueue via a runtime API
    • #3854 Unify SubstrateHostFunctions and cumulus_client_service::storage_proof_size::HostFunctions, into a single ParachainHostFunctions export from cumulus-client-service. NOTE: Changes applied in this PR
    • #3479 Changes in Polkadot's runtime to add support for backing and including multiple candidates of the same parachain if they form a chain
  • Runtime dev changes:
    • #3817 Refactor runtime APIs to be in their own api.rs file in the template parachain. NOTE: Refactor done for StorageHub in this PR
    • #3607 Runtime APIs for XCM to estimate fees, useful for UIs that are used to send XCMs
    • #3792 Fix transport fees for XCM remote reserve transfers
    • #3740 & #3783 & #3471 & #3350 Remove pallet::getter usage from a few pallets. NOTE: Refactor to follow this philosophy applied in this PR, the syntax StorageItem::<T, I>::get() is used instead
    • #3927 Deprecated teleport_assets and reserve_transfer_assets. NOTE: No change needed since we use the generic transfer_assets
    • #3654 Removed experimental flag from pallet-aura since async backing relies on that functionality. NOTE: Updated StorageHub runtime to reflect this in this PR.
    • #3749 Deprecate execute and send for execute_blob and send_blob. NOTE: Updated xcm-simulator tests to change deprecated functions in this PR.
    • #3844 Add the ability to process XCM messages during on_idle. NOTE: Implemented in this PR, but IdleMaxServiceWeight (the maximum weight to be used from remaining weight for processing enqueued messages on idle) is set to a placeholder, we should update it after benchmarking.
    • #3696 Add HRMP notification handlers to the xcm-executor (HrmpNewChannelOpenRequestHandler, HrmpChannelAcceptedHandler and HrmpChannelClosingHandler). This is useful to have an automatic way to react to HRMP channels instead of having to go through governance. NOTE: Left the default () type on the config, we could explore if it's worth it to implement something with this.
  • Runtime user changes:
    • #3341 Fix schedule_code_upgrade to not wait for the parachain to progress (useful to know, it's now easier to unbrick a parachain)
    • Related to #3749, there's a new utility in PolkadotJS apps for encoding XCMs: https://polkadot.js.org/apps/#/utilities/xcm that you can use to use execute_blob and send_blob (which require as input the encoded XCM)

Critical warning: since storage from cumulus-pallet-parachain-system is made public in polkadot-sdk v1.13.0 and its pallet::getters have been removed, we have to mock getting from its storage. This HAS to be removed when upgrading to v1.13.0.

@TDemeco TDemeco requested review from ffarall and snowmead September 27, 2024 21:10
@TDemeco TDemeco changed the title upgrade: ⬆️ upgrade to polkadot-sdk v1.10.0 feat: ⏫ upgrade to Polkadot SDK v1.10.0 Sep 30, 2024
Copy link
Contributor

@snowmead snowmead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beast!

Copy link
Contributor

@ffarall ffarall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, remarkable work. Very tidy and organised, and excellent PR docs on what were the changes.

Solve conflicts and ready to merge.

Comment on lines 7 to 8
use sp_trie::Trie;
use sp_trie::{TrieDBBuilder, TrieLayout};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use sp_trie::Trie;
use sp_trie::{TrieDBBuilder, TrieLayout};
use sp_trie::{TrieDBBuilder, TrieLayout, Trie};

@TDemeco TDemeco merged commit f347a67 into main Oct 3, 2024
21 checks passed
@TDemeco TDemeco deleted the update/polkadot-sdk-1.10.0 branch October 3, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants