[Tests-Only] Moved getCollaboratorsList and getCollaboratorsListNames command into collabratorsDialog #3095
+114
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kiranparajuli589
requested review from
kiranparajuli589,
haribhandari07 and
jasson99
| module.exports = { | ||
| commands: { | ||
| /** | ||
| * @param collaborator |
There was a problem hiding this comment.
Suggested change
| * @param collaborator | |
| * @param {string} collaborator |
| @@ -4,6 +4,9 @@ const federationSharePostfix = '\nRemote user' | |||
| const util = require('util') | |||
| const _ = require('lodash') | |||
| const { COLLABORATOR_PERMISSION_ARRAY } = require('../../helpers/sharingHelper') | |||
| const { client } = require('nightwatch-api') | |||
|
|
|||
| @@ -146,7 +149,7 @@ module.exports = { | |||
| * @param {string} permissions | |||
| */ | |||
| shareWithUserOrGroup: async function (sharee, shareWithGroup = false, role, permissions, remote = false) { | |||
| await this.clickCreateShare() | |||
| await this.api.page.FilesPageElement.SharingDialog.collaboratorsDialog().clickCreateShare() | |||
There was a problem hiding this comment.
now you can use var collaboratorDialog
swoichha
force-pushed
the
sharingDialog-PageObjectSplit-getCollaboratorsList
branch
2 times, most recently
from
8318c09 to
aff2e05
Compare
jasson99
reviewed
Feb 27, 2020
| deleteShareWithUserGroup: function (item) { | ||
| const informationSelector = util.format(this.elements.collaboratorInformationByCollaboratorName.selector, item) | ||
| deleteShareWithUserGroup: function (collaborator) { | ||
| const informationSelector = util.format(this.elements.collaboratorInformationByCollaboratorName.selector, collaborator) |
There was a problem hiding this comment.
Please make sure you dont cross the vertical line on the screen.. Try to make lines shorter.
swoichha
force-pushed
the
sharingDialog-PageObjectSplit-getCollaboratorsList
branch
from
aff2e05 to
a5e2674
Compare
individual-it
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Function
getCollaboratorsListandgetCollaboratorsListNamesalong with their related methods are moved from sharingDialog PageObject into collabratorsDialog.Related Issue
#2677
Motivation and Context
Appropriate placements for different PO methods and elements
How Has This Been Tested?
Types of changes
Checklist: