Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Moved deleteShareWithUserGroup command into collabratorsDialog #3082

Merged
merged 1 commit into from
Feb 26, 2020
Merged

[Tests-Only] Moved deleteShareWithUserGroup command into collabratorsDialog #3082

merged 1 commit into from
Feb 26, 2020

Conversation

swoichha
Copy link
Contributor

@swoichha swoichha commented Feb 24, 2020 •
edited
Loading

Description

Function deleteShareWithUserGroup and related methods are moved from sharingDialog PageObject into collabratorsDialog.

Related Issue

#2677

Motivation and Context

Appropriate placements for different PO methods and elements

How Has This Been Tested?

  • locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 removed the request for review from DeepDiver1975 February 24, 2020 09:34
@swoichha swoichha changed the title [Tests-Only] Moved deleteShareWithUserGroup command into collaboratorsContentPage [Tests-Only] Moved deleteShareWithUserGroup command into sharingDialogDetailsPage Feb 24, 2020
@individual-it individual-it requested review from kiranparajuli589, haribhandari07 and jasson99 and removed request for individual-it February 24, 2020 10:47
jasson99
jasson99 reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swoichha swoichha force-pushed the sharingDialogPageObjectSplit branch from 627474c to 72ba8bd Compare February 25, 2020 09:08
kiranparajuli589
kiranparajuli589 suggested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after making changes, please squash your all commits and push

tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js Show resolved Hide resolved
@swoichha swoichha force-pushed the sharingDialogPageObjectSplit branch 2 times, most recently from 06e9ecb to 9a00bc5 Compare February 26, 2020 03:42
@swoichha swoichha changed the title [Tests-Only] Moved deleteShareWithUserGroup command into sharingDialogDetailsPage [Tests-Only] Moved deleteShareWithUserGroup command into collabratorsDialog Feb 26, 2020
@swoichha swoichha force-pushed the sharingDialogPageObjectSplit branch from 9a00bc5 to 3a1eb63 Compare February 26, 2020 04:44
@kiranparajuli589 kiranparajuli589 merged commit e2c72e2 into owncloud:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@individual-it individual-it individual-it approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@jasson99 jasson99 Awaiting requested review from jasson99

Assignees

@swoichha swoichha

Labels
Status:Pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swoichha @individual-it @kiranparajuli589 @jasson99