Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate the sidebar completetly into an own pageObject #2677

Closed
individual-it opened this issue Dec 12, 2019 · 4 comments
Closed

separate the sidebar completetly into an own pageObject #2677

individual-it opened this issue Dec 12, 2019 · 4 comments
Assignees

Comments

@individual-it
Copy link
Member

Noticed while working on fixing tests for #2515
The sidebar xpath and work is scattered in different pageobjects: filesPage, filesList, appSideBar

consolidate and combine it all in a single object. Maybe we even need multiple objects for the different tabs.

This should be done on top of #2515 , because that PR changes the sidebar a lot

@individual-it
Copy link
Member Author

blocked by #2515

@kiranparajuli589 kiranparajuli589 self-assigned this Feb 15, 2020
@individual-it
Copy link
Member Author

@kiranparajuli589 @swoichha @haribhandari07 how far are we with this? Is it done?

@kiranparajuli589
Copy link
Contributor

Page Objects splitted so far:
1.appSideBar
2.versionsDialog
3.collabratorsDialog
4.publicLinksDialog
5.fileActionsMenu
6.expirationDatePicker

We can have more splits on public link and collaborator dialogs like making separte PO for dialogs to view shares log and forms to add shares.

@individual-it
Copy link
Member Author

Then lets close for now, more splitting is not priority currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants