Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm clients #7637

Merged
merged 16 commits into from
Mar 5, 2024
Merged

Wasm clients #7637

merged 16 commits into from
Mar 5, 2024

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

This is the same as #7503 but from a branch on our repo to see if that's the reason CI is failing

Testing and Verifying

all tests should pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 29, 2024

⚠️ The sha of the head commit of this PR conflicts with #7503. Mergify cannot evaluate rules on this PR. ⚠️

@nicolaslara nicolaslara added the V:state/breaking State machine breaking PR label Feb 29, 2024
@nicolaslara
Copy link
Contributor Author

same errors. Closing this

@nicolaslara nicolaslara closed this Mar 1, 2024
@nicolaslara nicolaslara reopened this Mar 1, 2024
@nicolaslara nicolaslara requested a review from a team as a code owner March 1, 2024 09:30
@github-actions github-actions bot added C:docs Improvements or additions to documentation T:CI labels Mar 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

Important Notice

This PR includes modifications to the tests/e2e/initialization module.
Please follow the instructions below:

  1. Backport these changes to the previous Osmosis version's branch.
  2. Run the script inside a Docker container to update genesis and configs for pre-upgrade Osmosis.
  3. Merge the backported changes.
  4. The image will be built and uploaded to Docker Hub here.
  5. Grab the latest image and update it in the PR to the main branch replacing the previousVersionInitTag in the osmosis/tests/e2e/containers/config.go

Please let us know if you need any help.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 1, 2024

⚠️ The sha of the head commit of this PR conflicts with #7503. Mergify cannot evaluate rules on this PR. ⚠️

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2024

⚠️ The sha of the head commit of this PR conflicts with #7503. Mergify cannot evaluate rules on this PR. ⚠️

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #7503. Mergify cannot evaluate rules on this PR. ⚠️

@mergify mergify bot mentioned this pull request Mar 5, 2024
Closed
6 tasks
@nicolaslara nicolaslara closed this Mar 5, 2024
@nicolaslara nicolaslara reopened this Mar 5, 2024
@nicolaslara nicolaslara merged commit 7fa4daa into main Mar 5, 2024
1 check passed
@nicolaslara nicolaslara deleted the wasm-clients branch March 5, 2024 17:37
@benluelo benluelo mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@AlpinYukseloglu AlpinYukseloglu Awaiting requested review from AlpinYukseloglu AlpinYukseloglu is a code owner

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation C:x/concentrated-liquidity T:CI V:state/breaking State machine breaking PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaslara @czarcas7ic @aeryz