Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce wasm light clients #7503

Closed
wants to merge 13 commits into from
Closed

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Feb 16, 2024

Closes: #XXX

What is the purpose of the change

Introduces the ibc wasm light clients module as we discussed in the telegram chat. There are a few notable parts:

  1. Although the ibc wasm light client module is capable of sharing the vm with x/wasm, we chose to go with a separate path in order to fully separate regular cosmwasm with light clients. See juno's recent post mortum for an example.
  2. When you compare the reference implementation and the code here, you'll see that they assign the DataDir without the home prefix but this will be fixed with this PR.

Testing and Verifying

We had to change the parallel tests to run sequential since the wasm light client module is using a global store key. This will not be necessary once we upgrade to ibc v8/sdk 0.50.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Feb 16, 2024
go.mod Outdated Show resolved Hide resolved
@aeryz aeryz requested a review from nicolaslara February 29, 2024 15:45
@aeryz aeryz marked this pull request as ready for review February 29, 2024 15:46
@nicolaslara nicolaslara added the V:state/breaking State machine breaking PR label Feb 29, 2024
@nicolaslara nicolaslara reopened this Feb 29, 2024
@nicolaslara nicolaslara mentioned this pull request Feb 29, 2024
6 tasks
@aeryz aeryz requested a review from a team as a code owner March 1, 2024 07:58
@github-actions github-actions bot added C:docs Improvements or additions to documentation T:CI labels Mar 1, 2024
@nicolaslara nicolaslara closed this Mar 4, 2024
@nicolaslara nicolaslara reopened this Mar 4, 2024
Copy link
Contributor

mergify bot commented Mar 5, 2024

⚠️ The sha of the head commit of this PR conflicts with #7637. Mergify cannot evaluate rules on this PR. ⚠️

@nicolaslara
Copy link
Contributor

closing this PR in favour of #7637 to avoid CI from going crazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:app-wiring Changes to the app folder C:docs Improvements or additions to documentation C:x/concentrated-liquidity T:CI V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants