Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osmosis devnet #1424

Closed
aeryz opened this issue Feb 22, 2024 · 3 comments
Closed

Add osmosis devnet #1424

aeryz opened this issue Feb 22, 2024 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@aeryz
Copy link
Contributor

aeryz commented Feb 22, 2024

When this PR gets merged, we should add osmosis to our devnet.

@benluelo
Copy link
Contributor

benluelo commented Mar 7, 2024

osmosis-labs/osmosis#7637 has been merged (linked to by osmosis-labs/osmosis#7503), are we able to add osmosis to our flake now? afaict theyre still on v47, which will require some changes to our devnet builder (see #1493)

@benluelo benluelo added C-enhancement Category: An issue proposing an enhancement or a PR with one. integration labels Mar 7, 2024
@aeryz
Copy link
Contributor Author

aeryz commented Mar 7, 2024

I would say that let's make the builder get the cli commands as parameter and specific builders define these params. For example in v0.50, it's binary genesis validate but in v47, its binary validate-genesis. And those kind of cli command changes are the only thing that we need to take care of.

@benluelo
Copy link
Contributor

benluelo commented Mar 8, 2024

yes, this is mentioned in #1493 - we'll need to handle multiple sdk versions. should hopefully be trivial

@aeryz aeryz closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

2 participants