[fix] Reduce tokenfactory gas fee #5468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackman27
force-pushed
the
sis/tokenfactory-reduce-gas
branch
from
c7bfc70 to
35736cc
Compare
p0mvn
reviewed
Jun 8, 2023
stackman27
commented
Jun 9, 2023
ValarDragon
reviewed
Jun 9, 2023
ValarDragon
approved these changes
Jun 9, 2023
mattverse
approved these changes
Jun 9, 2023
Co-authored-by: Matt, Park <[email protected]>
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5440
What is the purpose of the change
The current default mempool max gas per tx value is the old 25M value:
osmosis/cmd/osmosisd/cmd/root.go
Line 151 in c6697a5
max-gas-wanted-per-tx = "25000000"
Along with localosmosis instances, this apparently impacts edgenet? So transactions that exceed the 25M limit fail:
osmosis/x/tokenfactory/types/params.go
Line 16 in c6697a5
DefaultCreationGasFee = 40_000_000
Testing and Verifying
Documentation and Release Note
n/a
Where is the change documented?
x/{module}/README.md)