Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update max-gas-wanted-per-tx to 120M #5461

Closed
wants to merge 1 commit into from
Closed

update max-gas-wanted-per-tx to 120M #5461

wants to merge 1 commit into from

Conversation

DongLieu
Copy link
Contributor

@DongLieu DongLieu commented Jun 8, 2023

Closes: #5440

update max-gas-wanted-per-tx to 120M

@DongLieu
Copy link
Contributor Author

DongLieu commented Jun 8, 2023

image

@hieuvubk hieuvubk requested review from p0mvn and hieuvubk June 8, 2023 09:08
@hieuvubk hieuvubk added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Jun 8, 2023
ValarDragon
ValarDragon requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this, see my comment in issue.

Its the token factory code thats wrong. This is intentionally lower than block gas limit

@ValarDragon
Copy link
Member

Closing this in favor of #5468 !

@ValarDragon ValarDragon closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon requested changes

@mattverse mattverse mattverse approved these changes

@p0mvn p0mvn Awaiting requested review from p0mvn

@hieuvubk hieuvubk Awaiting requested review from hieuvubk

Assignees
No one assigned
Labels
A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default mempool max gas per tx to reflect current mainnet
4 participants
@DongLieu @ValarDragon @mattverse @hieuvubk