-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default mempool max gas per tx to reflect current mainnet #5440
Comments
CC: @DongLieu |
ok, tkank you |
No this conclusion isn't right, the max gas wanted per tx should stay the same, its the token factory setting thats wrong. We should change that to like 1M gas in my opinion. |
Oh I see; I misunderstood the max gas aspect. Then yea, the problem behavior of the tokenfactory create denom still exists due to the gas cost of 40M violating the 25M per-tx limit. |
Thanks for flagging the problem, great catch! Definitely concerning this got so far along / denom creation has been bricked on testnet for people |
thanks, looks good to me! i generated this issue by spinning up a localosmosis container, and then dispatching the tokenfactory's create denom message. for testing #5468, i just pointed the repo to the sis/tokenfactory-reduce-gas branch, and rebuilt the container. the readme.md below roughly outlines the steps i took (except i didn't manually update the gas per tx config): |
Background
The current default mempool max gas per tx value is the old 25M value:
osmosis/cmd/osmosisd/cmd/root.go
Line 151 in c6697a5
Along with localosmosis instances, this apparently impacts edgenet? So transactions that exceed the 25M limit fail:
osmosis/x/tokenfactory/types/params.go
Line 16 in c6697a5
Suggested Design
Please update to 120M to reflect current mainnet.
Acceptance Criteria
When spinning up a localosmosis container, $HOME/.osmosisd-local/config/app.toml's "max-gas-wanted-per-tx" should equal "120000000", like below:
The text was updated successfully, but these errors were encountered: