Consensus min gas fee of .0025 uosmo #4244

ValarDragon · 2023-02-07T08:50:22Z

Cref #3320 , does the raw osmo amount component, not the TWAP.

What is the purpose of the change

Implements a consensus min gas fee of .0025 uosmo / gas. The mempool policy is set to max(localMempoolPolicy, Consensus minimum)

This consensus minimum is not being exposed as a governance parameter right now, as it seems far more effective to get to adaptive, demand based fee markets (ala EIP-1559).

Brief Changelog

Implement a consensus min fee of .0025uosmo/gas as per Osmosis proposal 354 https://www.mintscan.io/osmosis/proposals/354 .

Testing and Verifying

I've updated the existing test vectors to account for the consensus minimum, which includes adapting no fee and sub-consensus minimum test vectors to fail. Furthermore this PR refactors the test vector setup to be more succinct. (Removing extraneous fields, and using a for loop to combine Check and Deliver)

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? yes
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
How is the feature or change documented? Yes

ValarDragon · 2023-02-07T08:52:07Z

x/txfees/keeper/feedecorator_test.go

-			name:  "doesn't work with not enough converted fee in checktx",
-			txFee: sdk.NewCoins(sdk.NewInt64Coin(uion, 1)),
-			minGasPrices: sdk.NewDecCoins(sdk.NewDecCoinFromDec(baseDenom,
-				sdk.MustNewDecFromStr("0.1"))),
-			gasRequested: 10000,
-			isCheckTx:    true,
-			expectPass:   false,
-			baseDenomGas: false,
-		},
-		{
-			name:  "works with not enough converted fee in delivertx",
-			txFee: sdk.NewCoins(sdk.NewInt64Coin(uion, 1)),
-			minGasPrices: sdk.NewDecCoins(sdk.NewDecCoinFromDec(baseDenom,
-				sdk.MustNewDecFromStr("0.1"))),
-			gasRequested: 10000,
-			isCheckTx:    false,
-			expectPass:   true,
-			baseDenomGas: false,
-		},
-		{
-			name:         "multiple fee coins - checktx",
-			txFee:        sdk.NewCoins(sdk.NewInt64Coin(baseDenom, 1), sdk.NewInt64Coin(uion, 1)),
-			minGasPrices: sdk.NewDecCoins(),
-			gasRequested: 10000,
-			isCheckTx:    true,
-			expectPass:   false,
-			baseDenomGas: false,
-		},
-		{
-			name:         "multiple fee coins - delivertx",
-			txFee:        sdk.NewCoins(sdk.NewInt64Coin(baseDenom, 1), sdk.NewInt64Coin(uion, 1)),
-			minGasPrices: sdk.NewDecCoins(),
-			gasRequested: 10000,
-			isCheckTx:    false,
-			expectPass:   false,
-			baseDenomGas: false,
-		},


Moved to be deduplicated across check/deliver

ValarDragon · 2023-02-07T08:52:22Z

x/txfees/keeper/feedecorator_test.go

-			expectPass:   true,
-			baseDenomGas: true,
+			isCheckTx:  true,
+			expectPass: true,
 		},


Deduplicated above

ValarDragon · 2023-02-07T08:52:40Z

x/txfees/keeper/feedecorator_test.go

-		{
-			name:         "no min gas price - checktx",
-			txFee:        sdk.NewCoins(),
-			minGasPrices: sdk.NewDecCoins(),
-			gasRequested: 10000,
-			isCheckTx:    true,
-			expectPass:   true,
-			baseDenomGas: true,
-		},
-		{
-			name:         "no min gas price - delivertx",
-			txFee:        sdk.NewCoins(),
-			minGasPrices: sdk.NewDecCoins(),
-			gasRequested: 10000,
-			isCheckTx:    false,
-			expectPass:   true,
-			baseDenomGas: true,
-		},


Changed to be consensus min gas failure tests.

ValarDragon · 2023-02-07T08:55:02Z

x/txfees/keeper/feedecorator_test.go

+					if tc.txFee[0].Denom != baseDenom {
+						moduleName = types.NonNativeFeeCollectorName
+					}


Base denom gas was an unnecessary field, its role is automated with this if statement.

ValarDragon · 2023-02-07T09:10:36Z

The failure in go tests is that our ibc-hooks tests use ibctesting. Ibctesting uses 0 fees in its tests, right here: https://github.com/cosmos/ibc-go/blob/v4.3.0/testing/chain.go#L312-L322

mattverse

LGTM 🌮

x/txfees/keeper/feedecorator_test.go

x/txfees/types/constants.go

Co-authored-by: Matt, Park <[email protected]>

tests/e2e/containers/containers.go

p0mvn · 2023-02-14T07:51:15Z

tests/e2e/initialization/config.go

+	// setup fee pool, between "e2e_default_fee_token" and "uosmo"
+	feePoolParams := balancer.NewPoolParams(sdk.MustNewDecFromStr("0.01"), sdk.ZeroDec(), nil)
+	feePoolAssets := []balancer.PoolAsset{
+		{
+			Weight: sdk.NewInt(100),
+			Token:  sdk.NewCoin("uosmo", sdk.NewInt(100000000000)),
+		},
+		{
+			Weight: sdk.NewInt(100),
+			Token:  sdk.NewCoin(E2EFeeToken, sdk.NewInt(100000000000)),
+		},
+	}
+	pool1, err := balancer.NewBalancerPool(1, feePoolParams, feePoolAssets, "", time.Unix(0, 0))
+	if err != nil {
+		panic(err)
+	}
+	anyPool, err := types1.NewAnyWithValue(&pool1)
+	if err != nil {
+		panic(err)
+	}
+	gammGenState.Pools = []*types1.Any{anyPool}
+	gammGenState.NextPoolNumber = 2


Can we remove this and instead re-create this via CLI?

This interferes with pool IDs that we are creating via CLI

Two questions:

Why does it interfere?

Where do I do it in CLI such that it comes first? It needs to be first so that other txs can pay fees, and we'd have to make distinct custom methods for paying fees to set this up.

The reason is that we also create pre-upgrade pools as a result the pool id of 1 is already assigned after upgrade. It is possible to work around this by first making a separate PR to v14 genesis.

Makes sense. I will work around number 1 then and make the changes to v14 before main

Actually, for 2, it should be possible to create a pool with the fee via pool file, right?

The pool file doesn't contain the tx fee. (Adding something custom for the tx fee for initialization isn't really a big deal. It just has to come first, if you point me to where I do that, I can add it in relatively easily)

p0mvn · 2023-02-14T15:56:32Z

tests/e2e/configurer/chain/commands.go

@@ -127,7 +128,7 @@ func (n *NodeConfig) SendIBCTransfer(from, recipient, amount, memo string) {

 	cmd := []string{"osmosisd", "tx", "ibc-transfer", "transfer", "transfer", "channel-0", recipient, amount, fmt.Sprintf("--from=%s", from), "--memo", memo}

-	_, _, err := n.containerManager.ExecTxCmdWithSuccessString(n.t, n.chainId, n.Name, cmd, "code: 0")
+	_, _, err := n.containerManager.ExecTxCmd(n.t, n.chainId, n.Name, cmd)


Why was this done?

This was a driveby change to get the execution stack to have one entry point. (At the time I did this line, I thought I'd do the gas if statement in this method, ended up not doing that)

So can be reverted, but looks identical to the ExecTxCmd as far as I can tell?

Yeah I think this is fine, was getting sidetracked by this but the change LGTM now.

I think I found the main problem. Should have the fix soon

* chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue

p0mvn · 2023-02-16T10:47:29Z

I think we can disable geometric TWAP as well. These are likely related. I'm still investigating separately

* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit 05fda4d)

* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit 05fda4d) Co-authored-by: Dev Ojha <[email protected]>

* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]>

ValarDragon added 6 commits February 7, 2023 16:56

Refactor tests a bit

dfe43ca

Add consensus min gas fee

38946b7

Fix tests

c676d48

Delete more crud

923b45e

Cleanup more duplicate test cases

7a82e14

flip isCheckTx sign

125d59d

ValarDragon added the V:state/breaking State machine breaking PR label Feb 7, 2023

github-actions bot added the C:x/txfees label Feb 7, 2023

ValarDragon commented Feb 7, 2023

View reviewed changes

ValarDragon added 2 commits February 7, 2023 17:53

One more test needed

13679ce

Run invalid fee denom test across both check & deliver

295aebb

ValarDragon commented Feb 7, 2023

View reviewed changes

Remove extra line

a374529

ValarDragon mentioned this pull request Feb 7, 2023

Move ibctesting testchain to tests #4247

Merged

ValarDragon added 4 commits February 8, 2023 00:48

Merge branch 'main' into dev/consensus_min_gas_fee

8c7f27d

Add hack to get around txfee problem in ibctesting

e42e675

Handle genesis

f40b0c7

Minor code cleanup

b278a48

ValarDragon requested review from czarcas7ic and mattverse February 8, 2023 05:26

tryfix simulation

5db078c

github-actions bot added the C:simulator Edits simulator or simulations label Feb 8, 2023

mattverse approved these changes Feb 8, 2023

View reviewed changes

x/txfees/keeper/feedecorator_test.go Show resolved Hide resolved

x/txfees/keeper/feedecorator_test.go Outdated Show resolved Hide resolved

x/txfees/keeper/feedecorator_test.go Outdated Show resolved Hide resolved

x/txfees/types/constants.go Show resolved Hide resolved

ValarDragon and others added 4 commits February 8, 2023 15:58

Fix for legacy simulator

a8b5c4c

Update x/txfees/keeper/feedecorator_test.go

275cfb8

Co-authored-by: Matt, Park <[email protected]>

Apply matt comments

e7db7e1

See what happens by adding fees

1896d2e

nicolaslara reviewed Feb 8, 2023

View reviewed changes

tests/e2e/containers/containers.go Outdated Show resolved Hide resolved

ValarDragon added the A:backport/v15.x backport patches to v15.x branch label Feb 8, 2023

ValarDragon added 5 commits February 13, 2023 14:08

Merge branch 'main' into dev/consensus_min_gas_fee

f3ffdcb

Add genesis logic update

bf1b8bc

Try fixing e2e

81ea3fd

Add some better logging to find error

efe1326

remove stat, fix typo

540eaff

p0mvn reviewed Feb 14, 2023

View reviewed changes

p0mvn added a commit that referenced this pull request Feb 14, 2023

chore(e2e) update v14.x genesis for #4244

2384a3d

p0mvn mentioned this pull request Feb 14, 2023

chore(e2e) update v14.x genesis for #4244 #4309

Merged

p0mvn added a commit that referenced this pull request Feb 14, 2023

chore(e2e) update v14.x genesis for #4244 (#4309)

4d4583f

p0mvn added a commit that referenced this pull request Feb 14, 2023

chore(e2e): update init image on main for #4244

27c6f27

p0mvn mentioned this pull request Feb 14, 2023

fix(e2e): fix e2e test for consensus min gas fee #4244 #4317

Merged

p0mvn reviewed Feb 14, 2023

View reviewed changes

fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317)

63c07fa

* chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue

github-actions bot added the C:docs Improvements or additions to documentation label Feb 16, 2023

Temp disable geo twap E2E

af6f4a0

ValarDragon merged commit 05fda4d into main Feb 16, 2023

ValarDragon deleted the dev/consensus_min_gas_fee branch February 16, 2023 14:32

mergify bot mentioned this pull request Feb 16, 2023

Consensus min gas fee of .0025 uosmo (backport #4244) #4347

Merged

p0mvn mentioned this pull request Feb 17, 2023

fix(x/twap): incorrect time delta due to nanoseconds in time #4359

Merged

github-actions bot mentioned this pull request Apr 15, 2024

Broken Links Detected #8046

Closed

github-actions bot mentioned this pull request Oct 15, 2024

Broken Links Detected notional-labs/osmosis#75

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consensus min gas fee of .0025 uosmo #4244

Consensus min gas fee of .0025 uosmo #4244

ValarDragon commented Feb 7, 2023

ValarDragon Feb 7, 2023

ValarDragon Feb 7, 2023

ValarDragon Feb 7, 2023

ValarDragon Feb 7, 2023

ValarDragon commented Feb 7, 2023 •

edited

Loading

mattverse left a comment

p0mvn Feb 14, 2023

ValarDragon Feb 14, 2023 •

edited

Loading

p0mvn Feb 14, 2023 •

edited

Loading

p0mvn Feb 14, 2023

ValarDragon Feb 14, 2023

p0mvn Feb 14, 2023

ValarDragon Feb 14, 2023

p0mvn Feb 14, 2023

p0mvn commented Feb 16, 2023 •

edited

Loading

Consensus min gas fee of .0025 uosmo #4244

Consensus min gas fee of .0025 uosmo #4244

Conversation

ValarDragon commented Feb 7, 2023

What is the purpose of the change

Brief Changelog

Testing and Verifying

Documentation and Release Note

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ValarDragon commented Feb 7, 2023 • edited Loading

mattverse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ValarDragon Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

p0mvn Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

p0mvn commented Feb 16, 2023 • edited Loading

ValarDragon commented Feb 7, 2023 •

edited

Loading

ValarDragon Feb 14, 2023 •

edited

Loading

p0mvn Feb 14, 2023 •

edited

Loading

p0mvn commented Feb 16, 2023 •

edited

Loading