fix(e2e): fix e2e test for consensus min gas fee #4244 #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
changed the title
p0mvn
changed the title
p0mvn
added
V:state/compatible/backport
ValarDragon
reviewed
Feb 15, 2023
| @@ -57,7 +58,8 @@ account_prefix = 'osmo' | |||
| key_name = 'val01-osmosis-b' | |||
| store_prefix = 'ibc' | |||
| max_gas = 6000000 | |||
| gas_price = { price = 0.000, denom = 'uosmo' } | |||
| default_gas = 400000 | |||
There was a problem hiding this comment.
Why are we putting default gas? Won't we get out of gas errors routinely?
There was a problem hiding this comment.
AFAIU, this is what the relayer assumes for calculating fees when estimation fails ref: informalsystems/hermes#1457
We use the value of 40k in the tx arguments as well so I just reused it.
There was a problem hiding this comment.
Btw, the only remaining problem is the geometric twap failing for reasons I cannot currently explain. Please let me know if something immediately comes to mind as the solution.
I'm going to keep investigating in the meantime
ValarDragon
added a commit
that referenced
this pull request
Feb 16, 2023
* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit 05fda4d)
ValarDragon
added a commit
that referenced
this pull request
Feb 16, 2023
* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]> (cherry picked from commit 05fda4d) Co-authored-by: Dev Ojha <[email protected]>
pysel
pushed a commit
that referenced
this pull request
Feb 18, 2023
* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]>
pysel
pushed a commit
that referenced
this pull request
Feb 21, 2023
* Refactor tests a bit * Add consensus min gas fee * Fix tests * Delete more crud * Cleanup more duplicate test cases * flip isCheckTx sign * One more test needed * Run invalid fee denom test across both check & deliver * Remove extra line * Add hack to get around txfee problem in ibctesting * Handle genesis * Minor code cleanup * tryfix simulation * Fix for legacy simulator * Update x/txfees/keeper/feedecorator_test.go Co-authored-by: Matt, Park <[email protected]> * Apply matt comments * See what happens by adding fees * Add genesis logic update * Try fixing e2e * Add some better logging to find error * remove stat, fix typo * fix(e2e): fix e2e test for consensus min gas fee #4244 (#4317) * chore(e2e): update init image on main for #4244 * changes * fix more problems * more fixes * lint * twap gebug logs * arithmetic fix * skip twap test * link issue * Temp disable geo twap E2E --------- Co-authored-by: Matt, Park <[email protected]> Co-authored-by: Roman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
This relates to #4244
SendIBCto exclude fee token from the balance check