Increasing allowed wasm bytecode size #4174
Conversation
|
I tested with our contract. It works. |
| func overrideWasmVariables() { | ||
| // Override Wasm size limitation from WASMD. | ||
| wasmtypes.MaxWasmSize = 2 * 1024 * 1024 | ||
| wasmtypes.MaxProposalWasmSize = wasmtypes.MaxWasmSize | ||
| } |
There was a problem hiding this comment.
Should we later make this a wasm option, and move this function elsewhere?
If so we can make a followup issue.
There was a problem hiding this comment.
yeah, I feel like wasmd configs are all over the place, but I don't know if there's a reason for that. For example, I often use a local fork to override defaultContractDebugMode (using --trace also adds that, but I think that doesn't work on tests and I don't want other side effects of adding trace).
But maybe there's something I'm missing. Do you know the right way to do this with apply()? Is that something we can define on osmosis or would it need to change in wasmd?
There was a problem hiding this comment.
OH its a lowercase apply not uppercase. I dont think we can implement the interface outside the repo, RIP.
Lets at least bundle all our wasm options, into perhaps an app/wasm.go
There was a problem hiding this comment.
added #4206 to reorganize this in the future.
There was a problem hiding this comment.
LGTM, but needs state breaking changelog. (And can you update #4170 )
Closes: #4171
What is the purpose of the change
Increase the max allowed wasm size to 2MB
Brief Changelog
Testing and Verifying
Added an E2E test uploading a large file. The test fails without the change.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)