-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase wasm size limit #14
Conversation
This should be done as a variable update in the Osmosis main repo. |
@ValarDragon can you point to where to make that change? I'm happy to make a PR for it but I couldn't see where wasmd vars are set there and a grep for |
@ValarDragon in our experimentation we had found that configuration updates were insufficient to change the WASM size, and that the hard-coded value in the code base needed to be changed. |
@snoyberg Where did you change it? do you have a branch/PR? (I would expect this to be changed on the osmosis repo in app/app.go) |
@nicolaslara This is what I have tried, it is not buildable. The error is:
|
ahh, it should just be Though, you may need to change it inside NewOsmosisApp using wasmtypes 🤔. Would need to test it to be sure |
I have tried without |
how are you testing it? just trying to upload a large contract? If you post one I can try to get this done |
@nicolaslara Sorry, I was a bit of stuck at testing. Just finished. I have updated the PR, removing The same contract worked with size change in wasmd. |
@nicolaslara I want to try "change it inside NewOsmosisApp using wasmtypes", but I have no idea what the change should be like. |
I'll give it a try and add an E2E test |
Thank you! |
added it in osmosis-labs/osmosis#4174 |
This increases the allowed WASM size from 800K to 2.6MB