Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase wasm size limit #14

Closed
wants to merge 1 commit into from
Closed

Conversation

dakom
Copy link

@dakom dakom commented Jan 17, 2023

This increases the allowed WASM size from 800K to 2.6MB

@ValarDragon
Copy link
Member

This should be done as a variable update in the Osmosis main repo.

@dakom
Copy link
Author

dakom commented Jan 24, 2023

@ValarDragon can you point to where to make that change? I'm happy to make a PR for it but I couldn't see where wasmd vars are set there and a grep for MaxWasmSize doesn't turn up anything

@snoyberg
Copy link

@ValarDragon in our experimentation we had found that configuration updates were insufficient to change the WASM size, and that the hard-coded value in the code base needed to be changed.

@nicolaslara
Copy link

@snoyberg Where did you change it? do you have a branch/PR? (I would expect this to be changed on the osmosis repo in app/app.go)

@Magicloud
Copy link

@nicolaslara This is what I have tried, it is not buildable. The error is:

go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20190905194746-02993c407bfb
# github.com/osmosis-labs/osmosis/v14/app
app/app.go:69:18: syntax error: unexpected ., expecting type
Reaping losing child 0x5588f64d4500 PID 242 
make[1]: *** [Makefile:102: build] Error 2

@nicolaslara
Copy link

nicolaslara commented Jan 30, 2023

ahh, it should just be MaxWasmSize without the wasmtypes. I can take a look at this later if that doesn't work.

Though, you may need to change it inside NewOsmosisApp using wasmtypes 🤔. Would need to test it to be sure

@Magicloud
Copy link

I have tried without wasmtypes, and it did not seem affecting anything. I am trying it again.

@nicolaslara
Copy link

how are you testing it? just trying to upload a large contract? If you post one I can try to get this done

@Magicloud
Copy link

@nicolaslara Sorry, I was a bit of stuck at testing. Just finished.

I have updated the PR, removing wasmtypes. It built, but it failed testing. I could not give you the contract as it is not mine or opensource. The contract is 918672 bytes in size. And I got error while deploying: code bytes cannot be longer than 819200 bytes: exceeds limit: invalid request.

The same contract worked with size change in wasmd.

@Magicloud
Copy link

@nicolaslara I want to try "change it inside NewOsmosisApp using wasmtypes", but I have no idea what the change should be like.

@nicolaslara
Copy link

I'll give it a try and add an E2E test

@snoyberg
Copy link

Thank you!

@nicolaslara
Copy link

added it in osmosis-labs/osmosis#4174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants