Set proper wasm bytecode size #4388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaslara
added
V:state/compatible/backport
p0mvn
approved these changes
Feb 22, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
* new wasm size * add changelog (cherry picked from commit ad8f3d1)
|
Oh interesting, didn't realize they had a distinction between gov upload size and main tx upload size |
|
me neither 😅 . Noticed it when I was looking into how small XCS needs to be to be uploaded before the upgrade. Turns out... we can just upload it now if it's via a proposal |
nicolaslara
added a commit
that referenced
this pull request
Feb 22, 2023
* new wasm size * add changelog (cherry picked from commit ad8f3d1) Co-authored-by: Nicolas Lara <[email protected]>
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4174 changed the maximum bytecode size to 2MB. I didn't realize at the time that the max size for wasm upload via proposals was already set to 3MB, so that change actually "decreesed" the maximum allowed bytecode size for mainnet (since most contracts are uploaded via proposals) and only increased it for the testnet and allowed uploaders.
What is the purpose of the change
This change sets the wasm bytecode size to 3MB for both proposals and allowed wallets.
Brief Changelog
All stored contract codes have a maximum of 3MB now
Testing and Verifying
all tests pass
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes /)