x/incentives: refactor create gauge and add to gauge fees to use txfees denom #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
stackman27
commented
Aug 2, 2022
|
Could you please add a changelog entry for this? This would be API breaking due to the constructor update. However, I think we should still backport this to v11 since it's not state-breaking |
p0mvn
reviewed
Aug 2, 2022
Comment on lines
+290
to
+292
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
This is technically a state break but the likelihood of this non-deterministically happening is low so I think we can still backport this
There was a problem hiding this comment.
Actually, since this is on the message path, it is possible to run out of gas. So I think we should avoid backporting
czarcas7ic
approved these changes
Aug 3, 2022
|
@czarcas7ic good to go Can't upset the simulator for too long :D |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2236
What is the purpose of the change
In
#2227we hard coded the fee denom for create gauge and add to gauge fees. This was done to minimize the changes for a smooth and expedited v11 release.However, the hard-coded denom causes issues with the simulator. Simulator assumes "stake" denom for majority of its tests by default. As a result, no account has the hard coded "uosmo" denom to pay the fee. The simulator doesn't run because no account has "uosmo", only "stake"
Brief Changelog
We should avoid backporting these changes to v11.x
Testing and Verifying
Use dynamic denom calculation instead of hardcoding it in these tests ;
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes)x/<module>/spec/) / Osmosis docs repo / not documented)