Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/incentives: refactor create gauge and add to gauge fees to use txfees denom #2236

Closed
p0mvn opened this issue Jul 26, 2022 · 2 comments · Fixed by #2283
Closed

x/incentives: refactor create gauge and add to gauge fees to use txfees denom #2236

p0mvn opened this issue Jul 26, 2022 · 2 comments · Fixed by #2283
Assignees
Labels

Comments

@p0mvn
Copy link
Member

p0mvn commented Jul 26, 2022

Background

In #2227, we hard coded the fee denom for create gauge and add to gauge fees. This was done to minimize the changes for a smooth and expedited v11 release.

However, the hard-coded denom causes issues with the simulator. Simulator assumes "stake" denom for majority of its tests by default. As a result, no account has the hard coded "uosmo" denom to pay the fee.

We had to disable simulator in the incentives tests for now.

Suggested Design

We should revert the following 3 commits separately and avoid backporting them to v11.x:

Acceptance Criteria

  • create gauge and add to gauge fee uses denom from the txfees keeper
  • simulator incentives tests function correctly
@stackman27
Copy link
Contributor

Hi @p0mvn is this being worked on?

@p0mvn
Copy link
Member Author

p0mvn commented Jul 27, 2022

Hi @stackman27 . No, please feel free to take this if you'd like

@stackman27 stackman27 self-assigned this Jul 27, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants