feat(incentives)!: create gauge and add to gauge fee charge #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test create gauge fees * add mod account to test * test create gauge fees * add mod account to test * move to msg server * merge
…osis into roman/txfees-simplified
sunnya97
reviewed
Jul 24, 2022
p0mvn
commented
Jul 25, 2022
…osis into roman/txfees-simplified
|
Simulator was failing because we are essentially explicitly requiring the "uosmo" denom for the fees and we use the "stake" denom for the simulator. Normally I would just change the parameters from uosmo to stake, but because we are defining this directly in the msg_server, I am unable to override it. Regardless, I added a check in the simulator to only allow account with enough tokens in fees to create/add to gauges. Because no account has uosmo all attempts fail but the simulator will pass |
czarcas7ic
approved these changes
Jul 25, 2022
czarcas7ic
added a commit
that referenced
this pull request
Jul 26, 2022
* feat(incentives)!: create gauge and add to gauge fee charge * initialize txfees keeper before incentives * finish TestChargeFee * refactor to charge fee in message server * more tests * clean up * test balances * test create gauge fees (#2228) * test create gauge fees * add mod account to test * test create gauge fees * add mod account to test * move to msg server * merge * add comments * account keeper comment * fix TestCreateGaugeFee * apply appparams.BaseCoinUnit * remove txfees keeper from incentives and revert order * clean up * remove unused keepers fromm incentives keeper * Update x/incentives/keeper/gauge.go * Update x/incentives/keeper/gauge.go * clean up * fixture names * chargeFeeIfSufficientFeeDenomBalance test name * changelog * comment * finished tests (#2230) * finished tests * use keeper instead of math * remove unused tests * clean up * sim only allow accounts with enough to pay fee * lint * move fee to types and reuse in simulation (#2234) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]>
czarcas7ic
added a commit
that referenced
this pull request
Jul 26, 2022
…2227) (#2237) * feat(incentives)!: create gauge and add to gauge fee charge (#2227) * feat(incentives)!: create gauge and add to gauge fee charge * initialize txfees keeper before incentives * finish TestChargeFee * refactor to charge fee in message server * more tests * clean up * test balances * test create gauge fees (#2228) * test create gauge fees * add mod account to test * test create gauge fees * add mod account to test * move to msg server * merge * add comments * account keeper comment * fix TestCreateGaugeFee * apply appparams.BaseCoinUnit * remove txfees keeper from incentives and revert order * clean up * remove unused keepers fromm incentives keeper * Update x/incentives/keeper/gauge.go * Update x/incentives/keeper/gauge.go * clean up * fixture names * chargeFeeIfSufficientFeeDenomBalance test name * changelog * comment * finished tests (#2230) * finished tests * use keeper instead of math * remove unused tests * clean up * sim only allow accounts with enough to pay fee * lint * move fee to types and reuse in simulation (#2234) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Adam Tucker <[email protected]> * merge gauge fee changes * go mod updates Co-authored-by: Roman <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2191
What is the purpose of the change
This change introduces a message fee for creating and adding to gauge.
Create gauge has a fee of 50 OSMO while adding to gauge 25. The feel is always subtracted in OSMO.
If the user does not have enough OSMO to create/add to gauge + pay the fee, no action is done and the message server returns an error.
Brief Changelog
chargeFeeIfSufficientFeeDenomBalancemethod create on the keeperchargeFeeIfSufficientFeeDenomBalanceCreateGaugein theincentivesmessage serverchargeFeeIfSufficientFeeDenomBalanceis called fromCreateGaugeinincentivesmessage serverAddToGaugein theincentivesmessage serverchargeFeeIfSufficientFeeDenomBalanceis called fromAddToGaugeinincentivesmessage serverTesting and Verifying
This change added tests and can be verified as follows:
TestCreateGauge_FeeTestAddToGauge_FeeTestChargeFeeIfSufficientFeeDenomBalanceDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? yes