Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A much smaller set of newly enabled linters #1127

Merged
merged 5 commits into from
Mar 23, 2022
Merged

Conversation

faddat
Copy link
Member

@faddat faddat commented Mar 22, 2022

Description

This PR enables many more linters, but not nearly as many as the one that it is replacing.

The reason it hits so many files is this:

https://github.com/mvdan/gofumpt

From here, we can re-enable additional linters in .golangci.yml as needed.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #1127 (d3be4b2) into main (d143d83) will decrease coverage by 0.02%.
The diff coverage is 39.28%.

@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
- Coverage   20.21%   20.19%   -0.03%     
==========================================
  Files         199      199              
  Lines       25062    25088      +26     
==========================================
  Hits         5066     5066              
- Misses      19069    19095      +26     
  Partials      927      927              
Impacted Files Coverage Δ
osmomath/math.go 64.44% <ø> (ø)
store/node.go 66.94% <ø> (ø)
v043_temp/address/hash.go 80.00% <ø> (ø)
x/claim/abci.go 0.00% <ø> (ø)
x/claim/client/cli/query.go 34.45% <ø> (ø)
x/claim/client/cli/tx.go 0.00% <ø> (ø)
x/claim/handler.go 0.00% <ø> (ø)
x/claim/keeper/claim.go 64.33% <ø> (ø)
x/claim/keeper/grpc_query.go 0.00% <ø> (ø)
x/claim/keeper/hooks.go 28.00% <ø> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d143d83...d3be4b2. Read the comment docs.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through a bunch of the changes and it LGTM. I left one minor comment on the config file.

Also, this might clobber a bit with the removed annotations in the import blocks in my PR #1125, but I can resolve conflicts if need be.

.golangci.yml Outdated Show resolved Hide resolved
app/upgrades/v5/whitelist_feetokens.go Outdated Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! Thanks for pairing this down from the prior PR. RIP I made merge conflicts with merging #1129 , I'll fix the conflicts here

@ValarDragon
Copy link
Member

ValarDragon commented Mar 23, 2022

Actually, if its ok with you all, I'd really like to disable godot. (We can keep the changes)

godot just feels like an unnecessary headache. Also we need to update make lint to have parity with this.

I think we should also remove gofumpt until we make the Makefile easily install gofumpt and make make lint auto-gofumpt. (Realistically, also should see if gofumpt has simple vscode support. If it doesn't, I'd rather not add the friction of it personally)

@ValarDragon
Copy link
Member

ValarDragon commented Mar 23, 2022

Latest commit:

  • Updates make lint to use the config file
  • removes godot (indefinitely if noone has other thoughts)
  • removes gofumpt (only until we get make lint auto-format integration sorted & vscode / makefile installation worked out)

@faddat if you think this is good, we can go ahead and merge

@alexanderbez
Copy link
Contributor

Sounds good to me @ValarDragon

@faddat
Copy link
Member Author

faddat commented Mar 23, 2022

this all sounds good to me. Just updating changelog now.

@faddat
Copy link
Member Author

faddat commented Mar 23, 2022

tis now good <3

@ValarDragon ValarDragon merged commit e90fc2d into main Mar 23, 2022
@ValarDragon ValarDragon deleted the faddat/linters2 branch March 23, 2022 16:30
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants