-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A much smaller set of newly enabled linters #1127
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1127 +/- ##
==========================================
- Coverage 20.21% 20.19% -0.03%
==========================================
Files 199 199
Lines 25062 25088 +26
==========================================
Hits 5066 5066
- Misses 19069 19095 +26
Partials 927 927
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed through a bunch of the changes and it LGTM. I left one minor comment on the config file.
Also, this might clobber a bit with the removed annotations in the import blocks in my PR #1125, but I can resolve conflicts if need be.
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well! Thanks for pairing this down from the prior PR. RIP I made merge conflicts with merging #1129 , I'll fix the conflicts here
Actually, if its ok with you all, I'd really like to disable godot. (We can keep the changes)
I think we should also remove |
Latest commit:
@faddat if you think this is good, we can go ahead and merge |
Sounds good to me @ValarDragon |
this all sounds good to me. Just updating changelog now. |
tis now good <3 |
Description
This PR enables many more linters, but not nearly as many as the one that it is replacing.
The reason it hits so many files is this:
https://github.com/mvdan/gofumpt
From here, we can re-enable additional linters in .golangci.yml as needed.
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer