chore: app package housekeeping #1125
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1125 +/- ##
==========================================
+ Coverage 19.90% 19.92% +0.01%
==========================================
Files 200 200
Lines 25498 25503 +5
==========================================
+ Hits 5076 5081 +5
Misses 19515 19515
Partials 907 907
Continue to review full report at Codecov.
|
app/app.go
Outdated
|
|
||
| // Osmosis application prarmeters |
There was a problem hiding this comment.
Do you think we should revert these comments / the prior ordering of imports here?
There was a problem hiding this comment.
You mean keep them?
Import blocks aren't meant to be annotated. If you think devs would really find them useful, I can revert :)
There was a problem hiding this comment.
@faddat was the one who added them, presumably he's found it helpful when explaining app.go's to people.
We could put the same comments in the AppKeepers struct though, I don't think theres anything particularly important about this info being in the imports
There was a problem hiding this comment.
Gotcha, yeah I mean I guess I can see how they're helpful, but then a few questions/points arise:
- Do I now too have to keep these up to date and add them for any new imports (burden on me)
- Import blocks become extremely verbose
@faddat are you against removing these annotations?
|
@ValarDragon can you merge this whenever you get a chance? |
Description
Some general linting and housekeeping to the
apppackage. Changes are meant to be non-contentious and ultimately make the code and style consistent and most importantly legible.Feel free to close/deny if deemed too contentious :)
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer