-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[x/gamm][Refactor] Follow-on cleanup to Gamm Refactor #1129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 19.90% 20.19% +0.28%
==========================================
Files 200 199 -1
Lines 25498 25062 -436
==========================================
- Hits 5076 5061 -15
+ Misses 19515 19074 -441
- Partials 907 927 +20
Continue to review full report at Codecov.
|
8bcf054
to
1802861
Compare
1802861
to
e4bc4ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have much context here, but it seems like we just moved things around for clarity and better architecture, so LGTM 👍
Thanks for pushing for more docs, added some for everything you pointed out! |
Followup cleanup from the gamm refactor, now deleting unused code, and shuffling around where structs are defined, and if functions are publicly exposed. This PR has no logic updates, it just moves definitions around.
It should be reviewable commit by commit.
For contributor use:
docs/
) or specification (x/<module>/spec/
)Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer