Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update image in standalone.tpl instead of standalone.py #203

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 21, 2024

Corrects changes from #199

The standalone.py is a generated file from standalone.tpl. Manual edits to standalone.tpl are overwritten by make standalone. Please refrain from changing standalone.py file manually.

@tumido
Copy link
Member Author

tumido commented Nov 21, 2024

cc @leseb.. Do you happen to know if we can do anything to make CI reject manual changes to standalone.py?

Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelClifford MichaelClifford merged commit b8d0275 into opendatahub-io:main Nov 21, 2024
1 check passed
@leseb
Copy link
Collaborator

leseb commented Nov 22, 2024

cc @leseb.. Do you happen to know if we can do anything to make CI reject manual changes to standalone.py?

#206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants