ci: fail if standalone.py changed and standalone.tpl did not #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
ci-fail-standalone-py-only-change
branch
5 times, most recently
from
cc1e077 to
d68ad8e
Compare
This commit adds to the pre-commit hook a check to verify that changes to standalone.py are accompanied by corresponding updates to standalone.tpl. The check will fail if standalone.py is updated without updating standalone.tpl ONLY if no components file(s) is/are updated. This ensures consistency between standalone.py and standalone.tpl, and prompts the user to run 'make standalone' if necessary. The check can be bypassed by adding the 'ignore-standalone-change' label to the pull request. Signed-off-by: Sébastien Han <[email protected]>
leseb
force-pushed
the
ci-fail-standalone-py-only-change
branch
from
d68ad8e to
ad04b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1d45668 ci: fail if standalone.py changed and standalone.tpl did not
commit 1d45668
Author: Sébastien Han [email protected]
Date: Fri Nov 22 10:03:33 2024 +0100