Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Generic DS image from MODH repo #199

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

szaher
Copy link
Contributor

@szaher szaher commented Nov 21, 2024

Description

  • Using a recent MODH image with the required dependencies to run standalone.py script.
  • update docs to add caution before using the provide NFS docker image as it should be used for test purposes only and not for production use.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Using a recent MODH image with the required dependencies to run
`standalone.py` script.
update docs to add caution before using the provide NFS docker
image as it should be used for test purposes only and not for
production use.

Signed-off-by: Saad <[email protected]>
@astefanutti astefanutti merged commit 3baa602 into opendatahub-io:main Nov 21, 2024
1 check passed
@szaher szaher deleted the use-notebook-image branch November 21, 2024 16:04
@tumido
Copy link
Member

tumido commented Nov 21, 2024

Merging of this PR causes issues: Any PR created on top of this PR - after it got merged, would actually revert it.

Please review/see #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants