Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp] Use confighttp.NewDefaultClientConfig instead of manually creating struct #35457

Open
26 of 29 tasks
mackjmr opened this issue Sep 27, 2024 · 1 comment
Open
26 of 29 tasks

[confighttp] Use confighttp.NewDefaultClientConfig instead of manually creating struct #35457

mackjmr opened this issue Sep 27, 2024 · 1 comment

Comments

@mackjmr
Copy link
Member

mackjmr commented Sep 27, 2024 •
edited
Loading

Component(s)

No response

Describe the issue you're reporting

Related to second point in: open-telemetry/opentelemetry-collector#9478 (comment).

Move away from manually creating confighttp.ClientConfig in favor of using confighttp.NewDefaultClientConfig.

This is necessary for the following components:

This will be done following conditions:

  • Fields that are currently different than the default will be updated after call to NewDefaultClientConfig
  • Fields that are same as default will not be set manually anymore
  • Fields that are set in the default but currently unset in above components will be either manually unset (for backwards compatibility) or will be updated to match default.

For the third point, I am unsure of which approach to follow. An example is the otlphttpexporter (#11273), where previously MaxIdleConns, MaxIdleConnsPerHost, MaxConnsPerHost and IdleConnTimeout were unset (equivalent of nil), which is different than the default which has values.

Core collector issue: open-telemetry/opentelemetry-collector#11274
@mackjmr mackjmr added the needs triage New item requiring triage label Sep 27, 2024
@mackjmr mackjmr mentioned this issue Sep 27, 2024
Closed
1 task
@ChrsMark ChrsMark mentioned this issue Sep 27, 2024
Merged
@crobert-1
Copy link
Member

Removing needs triage, sounds like a good idea to me.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 30, 2024
@github-actions github-actions bot mentioned this issue Oct 1, 2024
Closed
@rogercoll rogercoll mentioned this issue Oct 1, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/alertmanager] Use NewDefaultClientConfig instead of manuall…
c18ed36 
…y creating struct

This PR makes usage of NewDefaultClientConfig instead of manually creating the confighttp.ClientConfig struct.

Issue: open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/datadogexporter] Use NewDefaultClientConfig instead of manu…
cb0d4b4 
…ally creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/influxdb] Use NewDefaultClientConfig instead of manually cr…
a782f0a 
…eating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/logzio] Use NewDefaultClientConfig instead of manually crea…
7f54e40 
…ting struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mx-psi pushed a commit that referenced this issue Oct 1, 2024
@mackjmr
[exporter/datadogexporter, pkg/datadog, testbed] Use NewDefaultClient…
c621e78 
…Config instead of manually creating struct (#35519)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 1, 2024
@mackjmr
[exporter/loki] Use NewDefaultClientConfig instead of manually creati…
a6e8ec0 
…ng struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 1, 2024
Merged
mx-psi pushed a commit that referenced this issue Oct 1, 2024
@mackjmr
[exporter/alertmanager] Use NewDefaultClientConfig instead of manuall…
3ea141f 
…y creating struct (#35518)

**Description:** 
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/mezmo] Use NewDefaultClientConfig instead of manual…
49b3d08 
…ly creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/prometheusremotewrite] Use NewDefaultClientConfig i…
9db7ca8 
…nstead of manually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/signalfx] Use NewDefaultClientConfig instead of man…
6d5042d 
…ually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/splunkhec] Use NewDefaultClientConfig instead of ma…
52c4b7b 
…nually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Merged
mackjmr added a commit to mackjmr/opentelemetry-collector-contrib that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/sumologic] Use NewDefaultClientConfig instead of ma…
02b127f 
…nually creating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 2, 2024
Merged
mx-psi pushed a commit that referenced this issue Oct 2, 2024
@mackjmr
[chore] [exporter/signalfx] Use NewDefaultClientConfig instead of man…
52f731e 
…ually creating struct (#35543)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
MovieStoreGuy pushed a commit that referenced this issue Oct 23, 2024
@mackjmr
[chore] [internal/aws/ecsutil] Use confighttp.NewDefaultClientConfig …
b770e76 
…instead of manually creating struct (#35575)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
djaglowski pushed a commit that referenced this issue Oct 28, 2024
@mackjmr
[chore] [receiver/apachespark] Use NewDefaultClientConfig instead of …
859ea73 
…manually creating struct (#35578)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
jpbarto pushed a commit to jpbarto/opentelemetry-collector-contrib that referenced this issue Oct 29, 2024
@mackjmr @jpbarto
[chore] [receiver/apachespark] Use NewDefaultClientConfig instead of …
c969042 
…manually creating struct (open-telemetry#35578)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr mentioned this issue Oct 29, 2024
Open
5 tasks
andrzej-stencel pushed a commit that referenced this issue Oct 30, 2024
@mackjmr
[chore] [exporter/splunkhec] Use NewDefaultClientConfig instead of ma…
c40c6a6 
…nually creating struct (#35545)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this issue Nov 12, 2024
@mackjmr @zzhlogin
[chore] [exporter/splunkhec] Use NewDefaultClientConfig instead of ma…
6ba1550 
…nually creating struct (open-telemetry#35545)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
jpkrohling pushed a commit that referenced this issue Nov 26, 2024
@mackjmr @andrzej-stencel
[chore] [receiver/purefa] Use confighttp.NewDefaultClientConfig inste…
7a3fade 
…ad of manually creating struct (#35645)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457

---------

Co-authored-by: Andrzej Stencel <[email protected]>
jpkrohling pushed a commit that referenced this issue Nov 26, 2024
@mackjmr
[chore] [exporter/loki] Use NewDefaultClientConfig instead of manuall…
fa0fe10 
…y creating struct (#35526)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457
andrzej-stencel pushed a commit that referenced this issue Nov 27, 2024
@mackjmr @fatsheep9146
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manu…
4f5671a 
…ally creating struct (#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** #35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this issue Dec 5, 2024
@mackjmr @andrzej-stencel @shivanthzen
[chore] [receiver/purefa] Use confighttp.NewDefaultClientConfig inste…
8c65233 
…ad of manually creating struct (open-telemetry#35645)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Andrzej Stencel <[email protected]>
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this issue Dec 5, 2024
@mackjmr @shivanthzen
[chore] [exporter/loki] Use NewDefaultClientConfig instead of manuall…
7a9c74d 
…y creating struct (open-telemetry#35526)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this issue Dec 5, 2024
@mackjmr @fatsheep9146 @shivanthzen
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manu…
64664da 
…ally creating struct (open-telemetry#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this issue Dec 6, 2024
@mackjmr @andrzej-stencel @ZenoCC-Peng
[chore] [receiver/purefa] Use confighttp.NewDefaultClientConfig inste…
c5eb4dc 
…ad of manually creating struct (open-telemetry#35645)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Andrzej Stencel <[email protected]>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this issue Dec 6, 2024
@mackjmr @ZenoCC-Peng
[chore] [exporter/loki] Use NewDefaultClientConfig instead of manuall…
087a052 
…y creating struct (open-telemetry#35526)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this issue Dec 6, 2024
@mackjmr @fatsheep9146 @ZenoCC-Peng
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manu…
82ab418 
…ally creating struct (open-telemetry#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [receiver/flinkmetrics] Use confighttp.NewDefaultClientConfig…
52dd42a 
… instead of manually creating struct (open-telemetry#35615)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@rogercoll @sbylica-splunk
[chore] [receiver/elasticsearch] Use NewDefaultClientConfig instead o…
ee4934d 
…f manual initialization (open-telemetry#35509)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Similar to
open-telemetry#35452
but for the `elasticsearch` receiver.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#35457

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [receiver/apache] Use confighttp.NewDefaultClientConfig inste…
e02fbc3 
…ad of manually creating struct (open-telemetry#35576)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [receiver/expvar] Use confighttp.NewDefaultClientConfig inste…
657be94 
…ad of manually creating struct (open-telemetry#35614)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [exporter/prometheusremotewrite] Use NewDefaultClientConfig i…
24bb0c8 
…nstead of manually creating struct (open-telemetry#35542)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [exporter/logzio] Use NewDefaultClientConfig instead of manua…
100b796 
…lly creating struct (open-telemetry#35524)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@ChrsMark @sbylica-splunk
[receiver/nginx] Use NewDefaultClientConfig instead of manually creat…
62d2f2f 
…ing struct (open-telemetry#35452)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Similar to
open-telemetry/opentelemetry-collector#11273.
This PR makes usage of the `NewDefaultClientConfig` instead of manually
creating the `confighttp.ClientConfig` struct as part of
open-telemetry#35457.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#35457

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: ChrsMark <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [receiver/riak] Use confighttp.NewDefaultClientConfig instead…
163b125 
… of manually creating struct (open-telemetry#35650)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [receiver/rabbitmq] Use confighttp.NewDefaultClientConfig ins…
4883180 
…tead of manually creating struct (open-telemetry#35647)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [internal/aws/ecsutil] Use confighttp.NewDefaultClientConfig …
642733f 
…instead of manually creating struct (open-telemetry#35575)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [receiver/apachespark] Use NewDefaultClientConfig instead of …
93fb05a 
…manually creating struct (open-telemetry#35578)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [exporter/splunkhec] Use NewDefaultClientConfig instead of ma…
fa712e6 
…nually creating struct (open-telemetry#35545)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @andrzej-stencel @sbylica-splunk
[chore] [receiver/purefa] Use confighttp.NewDefaultClientConfig inste…
538b4e2 
…ad of manually creating struct (open-telemetry#35645)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Andrzej Stencel <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @sbylica-splunk
[chore] [exporter/loki] Use NewDefaultClientConfig instead of manuall…
69236b0 
…y creating struct (open-telemetry#35526)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@mackjmr @fatsheep9146 @sbylica-splunk
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manu…
4b5af88 
…ally creating struct (open-telemetry#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mackjmr @crobert-1