[chore] [receiver/purefb] Use confighttp.NewDefaultClientConfig instead of manually creating struct #35646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of manually creating struct **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457
29 tasks
evan-bradley
reviewed
Oct 7, 2024
|
All of this looks good to me, I'd like to test with an actual Pure FlashBlade before release. I'll do that testing this week. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@chrroberts-pure were you able to run the test ? These changes shouldn't have any changes to the client, just the way we build the config. |
chrroberts-pure
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thank you for the follow up. Tested and looks good to me @mackjmr
|
Thanks! @jpkrohling @evan-bradley are we good to merge ? |
evan-bradley
approved these changes
Oct 28, 2024
jpbarto
pushed a commit
to jpbarto/opentelemetry-collector-contrib
that referenced
this pull request
Oct 29, 2024
…ad of manually creating struct (open-telemetry#35646)
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ad of manually creating struct (open-telemetry#35646)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes usage of
NewDefaultClientConfiginstead of manually creating the confighttp.ClientConfig struct.Link to tracking Issue: #35457