Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct #35521

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Oct 1, 2024

Description:
This PR makes usage of NewDefaultClientConfig instead of manually creating the confighttp.ClientConfig struct.

Link to tracking Issue: #35457

…eating struct

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457
@mackjmr mackjmr requested a review from a team as a code owner October 1, 2024 12:44
@mackjmr mackjmr requested a review from fatsheep9146 October 1, 2024 12:44
@github-actions github-actions bot requested a review from jacobmarble October 1, 2024 12:44
@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 1, 2024
@mackjmr mackjmr changed the title [exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct [chore][exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct Oct 2, 2024
@mackjmr
Copy link
Member Author

mackjmr commented Oct 15, 2024

@fatsheep9146 can you please take a look ?

@mackjmr
Copy link
Member Author

mackjmr commented Oct 28, 2024

@atoulme @fatsheep9146 are we good to merge this ?

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@fatsheep9146 fatsheep9146 added the ready to merge Code review completed; ready to merge by maintainers label Nov 26, 2024
@andrzej-stencel andrzej-stencel merged commit 4f5671a into open-telemetry:main Nov 27, 2024
168 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 27, 2024
shivanthzen pushed a commit to shivanthzen/opentelemetry-collector-contrib that referenced this pull request Dec 5, 2024
…ally creating struct (open-telemetry#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
ZenoCC-Peng pushed a commit to ZenoCC-Peng/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2024
…ally creating struct (open-telemetry#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…ally creating struct (open-telemetry#35521)

**Description:**
This PR makes usage of `NewDefaultClientConfig` instead of manually
creating the confighttp.ClientConfig struct.

**Link to tracking Issue:** open-telemetry#35457

---------

Co-authored-by: Ziqi Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/influxdb ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants