-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct #35521
Merged
andrzej-stencel
merged 5 commits into
open-telemetry:main
from
mackjmr:mackjmr/use-newdefault-influxdbexporter
Nov 27, 2024
Merged
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct #35521
andrzej-stencel
merged 5 commits into
open-telemetry:main
from
mackjmr:mackjmr/use-newdefault-influxdbexporter
Nov 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating struct **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457
29 tasks
atoulme
approved these changes
Oct 2, 2024
mackjmr
changed the title
[exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct
[chore][exporter/influxdb] Use NewDefaultClientConfig instead of manually creating struct
Oct 2, 2024
ChrsMark
approved these changes
Oct 3, 2024
@fatsheep9146 can you please take a look ? |
@atoulme @fatsheep9146 are we good to merge this ? |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fatsheep9146
approved these changes
Nov 26, 2024
fatsheep9146
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Nov 26, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…ally creating struct (open-telemetry#35521) **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457 --------- Co-authored-by: Ziqi Zhao <[email protected]>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…ally creating struct (open-telemetry#35521) **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457 --------- Co-authored-by: Ziqi Zhao <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ally creating struct (open-telemetry#35521) **Description:** This PR makes usage of `NewDefaultClientConfig` instead of manually creating the confighttp.ClientConfig struct. **Link to tracking Issue:** open-telemetry#35457 --------- Co-authored-by: Ziqi Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/influxdb
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR makes usage of
NewDefaultClientConfig
instead of manually creating the confighttp.ClientConfig struct.Link to tracking Issue: #35457