-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle libnabo config mode #513
Conversation
Can one of the admins verify this patch? |
ok to test |
@sloriot I'm missing the intent of the PR. Can you describe what was not working or what you want to improve? |
I wanted to have the config mode of cmake working with libnabo. Indeed, if you use the config mode then libnabo will be reported as found but the cmake variables that pointmatcher expects are not set. As a side note, I also noticed that it is not possible to use pointmatcher with cmake without doing |
Any link with #514? and of course, if you want to propose another PR we will gladly review it! |
It indeed seems to be the same issue that my hack fixes at CGAL level. Since there was no such error in the past, I guess that some libnabo API is now exposed in pointmatcher (thus the need for the link). |
Thanks @sloriot ! |
…hbourSearch related to norlab-ulaval/libpointmatcher#514 employ fix from norlab-ulaval/libpointmatcher#513
…hbourSearch (#1117) related to norlab-ulaval/libpointmatcher#514 employ fix from norlab-ulaval/libpointmatcher#513
An alternative would be to set libnabo_INCLUDE_DIRS and libnabo_LIBRARIES in
libnabo-targets.cmake