Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link issue with pointmatcher #7498

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Jun 5, 2023

It's a bug on libpointmatcher side IMO as it should be part of the variables providing deps to link with. But let's test it first before opening a PR.

@sloriot
Copy link
Member Author

sloriot commented Jun 7, 2023

Successfully tested in CGAL-5.6-Ic-267

@lrineau lrineau self-assigned this Jun 7, 2023
@lrineau lrineau added this to the 5.6-beta milestone Jun 7, 2023
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 7, 2023
@lrineau lrineau modified the milestones: 5.6-beta, 5.4.5 Jun 7, 2023
lrineau added a commit that referenced this pull request Jun 7, 2023
lrineau added a commit that referenced this pull request Jun 7, 2023
@lrineau lrineau merged commit 6e649cc into CGAL:5.4.x-branch Jun 7, 2023
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Jun 7, 2023
@lrineau lrineau deleted the fix_libpointmatcher_link branch June 7, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants