fix for Undefined symbols for architecture x86_64: "Nabo::NearestNeighbourSearch<double... when link to libpointmatcher #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hbourSearch related to norlab-ulaval/libpointmatcher#514 employ fix from norlab-ulaval/libpointmatcher#513
|
From https://github.com/ethz-asl/libpointmatcher/pull/513/files, it seems we would not need to explicitly link to libnabo anymore. nabo has been added as private dependency to libpointmatcher. If the checks pass, I'll merge your MR in case that an older libpointmatcher is used. |
|
Thx for the PR! |
matlabbe
added a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When link to libpointmatcher master(https://github.com/ethz-asl/libpointmatcher) with libnabo master (https://github.com/ethz-asl/libnabo) compiler failed:
Undefined symbols for architecture x86_64:
"Nabo::NearestNeighbourSearch<double, Eigen::Matrix<double, -1, -1, 0, -1, -1> >::create(Eigen::Matrix<double, -1, -1, 0, -1, -1> const&, int, Nabo::NearestNeighbourSearch<double, Eigen::Matrix<double, -1, -1, 0, -1, -1> >::SearchType, unsigned int, ...
related to norlab-ulaval/libpointmatcher#514
and I employ a fix from norlab-ulaval/libpointmatcher#513 to fix this error.