test: minimal repl eval option test #5192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
repl
| const assert = require('assert'); | ||
| const repl = require('repl'); | ||
|
|
||
| { |
There was a problem hiding this comment.
Why this block is necessary?
There was a problem hiding this comment.
It's there so that if we write a subsequent test (such as to test that context is sent on tab completion), we can make sure there are no side effects (because the variables are scoped to the block).
There was a problem hiding this comment.
Due to block-scoped vars (i.e. let and const) this feature, though existing in es5, is now actually useful.
|
LGTM |
| eval: common.mustCall((cmd, context) => { | ||
| // Assertions here will not cause the test to exit with an error code | ||
| // so set a boolean that is checked in process.on('exit',...) instead. | ||
| evalCalledWithExpectedArgs = (cmd === 'foo\n' && context.foo === 'bar'); |
There was a problem hiding this comment.
I think the parens here are unnecessary?
There was a problem hiding this comment.
That's right. They're just there for clarity. If they're objectionable, I can remove them.
|
LGTM |
|
Landed in 90451a6 |
Trott
added a commit
that referenced
this pull request
Feb 12, 2016
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Belated LGTM FWIW. Thanks for picking this up. :-) |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
Fixes: nodejs#3544 PR-URL: nodejs#5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3544