-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repl,test: no test coverage for repl.start({ eval: fn }) #3544
Comments
I can't make this work, |
I think it originated in aad12d0 |
/cc @TooTallNate in that case. |
eval will be called with |
I've added a minimal test at #5192. I too am unable to get the repl to fire the eval function on tab completion. ??? Assuming I'm not just Doing It Wrong, there should probably be a separate issue filed for that. |
@Trott thoughts on LTS? |
I'd say yes, add to LTS. |
Filed #5232 for that. |
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: nodejs#3544 PR-URL: nodejs#5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Fixes: #3544 PR-URL: #5192 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
It looks like we have no test coverage for the
eval
option torepl.start()
. This should be remedied.The only test I can find that passes
eval
istest/parallel/test-repl-options.js
but it doesn't exercise its functionality, the callback is just a stub.The text was updated successfully, but these errors were encountered: