fs: check closing_ in FileHandle::Close #39472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
jasnell
changed the title
jasnell
force-pushed
the
maybe-fix-flaky-filehandle-readablestream-test
branch
from
e77b5fd to
71343ea
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Jul 20, 2021
|
Ok, I think I got it properly identified. The |
Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Refs: nodejs#39464 Signed-off-by: James M Snell <[email protected]>
jasnell
force-pushed
the
maybe-fix-flaky-filehandle-readablestream-test
branch
from
72a4621 to
39ea214
Compare
jasnell
added
author ready
danbev
pushed a commit
that referenced
this pull request
Jul 22, 2021
Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Signed-off-by: James M Snell <[email protected]> PR-URL: #39472 Refs: #39464 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in f1d3533. |
targos
pushed a commit
that referenced
this pull request
Jul 25, 2021
Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Signed-off-by: James M Snell <[email protected]> PR-URL: #39472 Refs: #39464 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 29, 2021
Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Signed-off-by: James M Snell <[email protected]> PR-URL: #39472 Refs: #39464 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Signed-off-by: James M Snell <[email protected]> PR-URL: #39472 Refs: #39464 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.
Since I'm not able to reproduce the failure locally, I don't yet know if this fixes the flaky failure in CI.
Refs: #39464
Signed-off-by: James M Snell [email protected]