Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: test-filehandle-readable-stream #39464

Closed
mcollina opened this issue Jul 20, 2021 · 4 comments
Closed

Flaky test: test-filehandle-readable-stream #39464

mcollina opened this issue Jul 20, 2021 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. stream Issues and PRs related to the stream subsystem.

Comments

@mcollina
Copy link
Member

Version

master

Platform

linux

Subsystem

fs

What steps will reproduce the bug?

In CI test-filehandle-readable-stream is failing

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_icu_x64/27956/testReport/junit/(root)/test/parallel_test_filehandle_readablestream/

node:internal/process/promises:246
          triggerUncaughtException(err, true /* fromPromise */);
          ^

[Error: EBADF: bad file descriptor, close] {
  errno: -9,
  code: 'EBADF',
  syscall: 'close'
}

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response
@mcollina
Copy link
Member Author

cc @jasnell

@targos targos added flaky-test Issues and PRs related to the tests with unstable failures on the CI. stream Issues and PRs related to the stream subsystem. labels Jul 20, 2021
@jasnell
Copy link
Member

jasnell commented Jul 20, 2021

I've been unable to reproduce the problem locally and the error message does not provide great clues. Still investigating

jasnell added a commit to jasnell/node that referenced this issue Jul 20, 2021
@jasnell
fs: closing closing_ in FileHandle::Close
e77b5fd 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Refs: nodejs#39464
Signed-off-by: James M Snell <[email protected]>
@jasnell jasnell mentioned this issue Jul 20, 2021
Closed
@jasnell
Copy link
Member

jasnell commented Jul 20, 2021 •
edited
Loading

Possible fix Fix in #39472

jasnell added a commit to jasnell/node that referenced this issue Jul 20, 2021
@jasnell
fs: check closing_ in FileHandle::Close
71343ea 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Refs: nodejs#39464
Signed-off-by: James M Snell <[email protected]>
jasnell added a commit to jasnell/node that referenced this issue Jul 20, 2021
@jasnell
fs: check closing_ in FileHandle::Close
39ea214 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Refs: nodejs#39464
Signed-off-by: James M Snell <[email protected]>
danbev pushed a commit that referenced this issue Jul 22, 2021
@jasnell @danbev
fs: check closing_ in FileHandle::Close
f1d3533 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39472
Refs: #39464
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danbev
Copy link
Contributor

danbev commented Jul 22, 2021

Closing this issue as #39472 has been merged.

@danbev danbev closed this as completed Jul 22, 2021
@danbev danbev mentioned this issue Jul 22, 2021
Closed
targos pushed a commit that referenced this issue Jul 25, 2021
@jasnell @targos
fs: check closing_ in FileHandle::Close
a04f9a6 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39472
Refs: #39464
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this issue Jul 29, 2021
@jasnell @richardlau
fs: check closing_ in FileHandle::Close
f8a3c4a 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39472
Refs: #39464
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this issue Jul 29, 2021
@jasnell @BethGriggs
fs: check closing_ in FileHandle::Close
72ad6d3 
Fix possible flaky failure. Keep uv_fs_close from being called twice
on the same fd.

Signed-off-by: James M Snell <[email protected]>

PR-URL: #39472
Refs: #39464
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mcollina @danbev @jasnell @targos